Return RequestErrorCode.NO_INDEX_GENERATED for search/refactoring requests.

Return RequestErrorCode.NO_INDEX_GENERATED for search/refactoring requests.

Also remove passing a SearchEngine instance into Quick assists/fixes - they don't use it.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=43819

[Brian Wilkerson, 2015-02-17 19:57:36]

LGTM

https://codereview.chromium.org/923103004/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/923103004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:130: if (searchEngine == null)
{
Would it be better to check 'index' in these cases?

[scheglov, 2015-02-17 20:01:02]

https://codereview.chromium.org/923103004/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/923103004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:130: if (searchEngine == null)
{
On 2015/02/17 19:57:36, Brian Wilkerson wrote:
> Would it be better to check 'index' in these cases?

Well, there is some inconsistency here.
We don't use index directly anywhere in search or refactorings.
But we use an implicit fact that when there is no index, there is also to a
search engine.
And unfortunately we have to report user and error about index.

[scheglov, 2015-02-17 20:02:05]

Committed patchset #1 (id:1) manually as 43819 (presubmit successful).