Return RequestErrorCode.NO_INDEX_GENERATED for search/refactoring requests.

pkg/analysis_server/lib/src/edit/edit_domain.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library edit.domain;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/collections.dart';
@@ skipping 99 matching lines @@
         formattedResult.selectionLength).toResponse(request.id);
   }
 
   Response getAssists(Request request) {
     var params = new EditGetAssistsParams.fromRequest(request);
     List<SourceChange> changes = <SourceChange>[];
     List<CompilationUnit> units =
         server.getResolvedCompilationUnits(params.file);
     if (units.isNotEmpty) {
       CompilationUnit unit = units[0];
-      List<Assist> assists =
-          computeAssists(searchEngine, unit, params.offset, params.length);
+      List<Assist> assists = computeAssists(unit, params.offset, params.length);
       assists.forEach((Assist assist) {
         changes.add(assist.change);
       });
     }
     // respond
     return new EditGetAssistsResult(changes).toResponse(request.id);
   }
 
   Response getAvailableRefactorings(Request request) {
+    if (searchEngine == null) {

[Brian Wilkerson, 2015/02/17 19:57:36]

Would it be better to check 'index' in these cases?

[scheglov, 2015/02/17 20:01:02]

Well, there is some inconsistency here.
We don't use index directly anywhere in search or refactorings.
But we use an implicit fact that when there is no index, there is also to a
search engine.
And unfortunately we have to report user and error about index.

+      return new Response.noIndexGenerated(request);
+    }
+    // prepare parameters
     var params = new EditGetAvailableRefactoringsParams.fromRequest(request);
     String file = params.file;
     int offset = params.offset;
     int length = params.length;
     // add refactoring kinds
     List<RefactoringKind> kinds = <RefactoringKind>[];
     // try EXTRACT_*
     if (length != 0) {
       kinds.add(RefactoringKind.EXTRACT_LOCAL_VARIABLE);
       kinds.add(RefactoringKind.EXTRACT_METHOD);
@@ skipping 22 matching lines @@
     List<AnalysisErrorFixes> errorFixesList = <AnalysisErrorFixes>[];
     List<CompilationUnit> units = server.getResolvedCompilationUnits(file);
     for (CompilationUnit unit in units) {
       engine.AnalysisErrorInfo errorInfo = server.getErrors(file);
       if (errorInfo != null) {
         LineInfo lineInfo = errorInfo.lineInfo;
         int requestLine = lineInfo.getLocation(offset).lineNumber;
         for (engine.AnalysisError error in errorInfo.errors) {
           int errorLine = lineInfo.getLocation(error.offset).lineNumber;
           if (errorLine == requestLine) {
-            List<Fix> fixes = computeFixes(searchEngine, unit, error);
+            List<Fix> fixes = computeFixes(unit, error);
             if (fixes.isNotEmpty) {
               AnalysisError serverError =
                   newAnalysisError_fromEngine(lineInfo, error);
               AnalysisErrorFixes errorFixes =
                   new AnalysisErrorFixes(serverError);
               errorFixesList.add(errorFixes);
               fixes.forEach((fix) {
                 errorFixes.fixes.add(fix.change);
               });
             }
@@ skipping 59 matching lines @@
     // do sort
     int fileStamp = context.getModificationStamp(source);
     String code = context.getContents(source).data;
     MemberSorter sorter = new MemberSorter(code, unit);
     List<SourceEdit> edits = sorter.sort();
     SourceFileEdit fileEdit = new SourceFileEdit(file, fileStamp, edits: edits);
     return new EditSortMembersResult(fileEdit).toResponse(request.id);
   }
 
   Response _getRefactoring(Request request) {
+    if (searchEngine == null) {
+      return new Response.noIndexGenerated(request);
+    }
     if (refactoringManager.hasPendingRequest) {
       refactoringManager.cancel();
       _newRefactoringManager();
     }
     refactoringManager.getRefactoring(request);
     return Response.DELAYED_RESPONSE;
   }
 
   /**
    * Initializes [refactoringManager] with a new instance.
@@ skipping 350 matching lines @@
     }
     if (refactoring is RenameRefactoring) {
       RenameRefactoring renameRefactoring = refactoring;
       RenameOptions renameOptions = params.options;
       renameRefactoring.newName = renameOptions.newName;
       return renameRefactoring.checkNewName();
     }
     return new RefactoringStatus();
   }
 }