Implement function entry breakpoints in Observatory debugger.

Implement function entry breakpoints in Observatory debugger.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=43782

[turnidge, 2015-02-13 06:48:24]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2015-02-13 19:30:52]

LGTMwC

https://codereview.chromium.org/920313003/diff/20001/runtime/observatory/lib/...
File runtime/observatory/lib/src/cli/command.dart (right):

https://codereview.chromium.org/920313003/diff/20001/runtime/observatory/lib/...
runtime/observatory/lib/src/cli/command.dart:193: Command parent = _parent;
var parent = _parent;

https://codereview.chromium.org/920313003/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/920313003/diff/20001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:323: }
add:

static intptr_t Interpret(const char* value) {
   strtol
}

and use it instead of GetIntegerId

https://codereview.chromium.org/920313003/diff/20001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:1774: static bool
HandleIsolateAddBreakpointAtEntry(Isolate* isolate,
The RPC is "addBreakpointAtEntry" so this function should be named
"AddBreakpointAtEntry". I'm going to do a pass soon which fixes up all of the
handle functions to match the corresponding RPC name.

[turnidge, 2015-02-13 22:37:20]

https://codereview.chromium.org/920313003/diff/20001/runtime/observatory/lib/...
File runtime/observatory/lib/src/cli/command.dart (right):

https://codereview.chromium.org/920313003/diff/20001/runtime/observatory/lib/...
runtime/observatory/lib/src/cli/command.dart:193: Command parent = _parent;
On 2015/02/13 19:30:52, Cutch wrote:
> var parent = _parent;

Acknowledged.

https://codereview.chromium.org/920313003/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/920313003/diff/20001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:323: }
On 2015/02/13 19:30:52, Cutch wrote:
> add:
> 
> static intptr_t Interpret(const char* value) {
>    strtol
> }
> 
> and use it instead of GetIntegerId

Done.  Changed the name to "Parse".

https://codereview.chromium.org/920313003/diff/20001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:1774: static bool
HandleIsolateAddBreakpointAtEntry(Isolate* isolate,
On 2015/02/13 19:30:52, Cutch wrote:
> The RPC is "addBreakpointAtEntry" so this function should be named
> "AddBreakpointAtEntry". I'm going to do a pass soon which fixes up all of the
> handle functions to match the corresponding RPC name.

Acknowledged.

[turnidge, 2015-02-13 22:37:50]

Committed patchset #5 (id:80001) manually as 43782 (presubmit successful).