Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1982)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 920313003: Implement function entry breakpoints in Observatory debugger. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/elements/debugger.dart ('k') | runtime/observatory/test/debugging_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 105709ba34237659f794ae0b1b3514ab6c9fd25b..460a372b8c43e9aacc604768266599024df4b354 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -1094,7 +1094,7 @@ class Isolate extends ServiceObjectOwner with Coverage {
Future<ServiceObject> addBreakpoint(Script script, int line) {
// TODO(turnidge): Pass line as an int instead of a string.
Map params = {
- 'script': script.id,
+ 'scriptId': script.id,
'line': '$line',
};
return invokeRpc('addBreakpoint', params).then((result) {
@@ -1116,6 +1116,17 @@ class Isolate extends ServiceObjectOwner with Coverage {
});
}
+ Future<ServiceObject> addBreakpointAtEntry(ServiceFunction function) {
+ return invokeRpc('addBreakpointAtEntry',
+ { 'functionId': function.id }).then((result) {
+ // TODO(turnidge): Instead of reloading all of the breakpoints,
+ // rely on events to update the breakpoint list.
+ return reloadBreakpoints().then((_) {
+ return result;
+ });
+ });
+ }
+
Future removeBreakpoint(Breakpoint bpt) {
return invokeRpc('removeBreakpoint',
{ 'breakpointId': bpt.id }).then((result) {
« no previous file with comments | « runtime/observatory/lib/src/elements/debugger.dart ('k') | runtime/observatory/test/debugging_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698