Improve _toInt64() and _toUint64() conversions in TypedData.

Improve _toInt64() and _toUint64() conversions in TypedData.
Add missing conversions of exponent and modulus in Bigint.modPow().
Fix typos in Bigint Classic reduction (modPow tests coming in later cl).
Address a few more TODOs.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43697

[regis, 2015-02-11 19:02:33]

regis@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2015-02-11 20:40:06]

lgtm

https://codereview.chromium.org/916153002/diff/1/runtime/lib/typed_data.dart
File runtime/lib/typed_data.dart (right):

https://codereview.chromium.org/916153002/diff/1/runtime/lib/typed_data.dart#...
runtime/lib/typed_data.dart:3593: if (cid == ClassID.cidSmi || cid ==
ClassID.cidMint) {
Please add parentheses.
Maybe instead of two tests you could only do:

return (cid == ClassID.cidBigint) ? _toInt(value, 0xFFFFFFFFFFFFFFFF) : value;

https://codereview.chromium.org/916153002/diff/1/runtime/lib/typed_data.dart#...
runtime/lib/typed_data.dart:3603: if (cid == ClassID.cidSmi || cid ==
ClassID.cidMint) {
ditto

[regis, 2015-02-11 20:51:07]

New patchsets have been uploaded after l-g-t-m from srdjan@google.com

[regis, 2015-02-11 20:51:17]

Thanks!

https://codereview.chromium.org/916153002/diff/1/runtime/lib/typed_data.dart
File runtime/lib/typed_data.dart (right):

https://codereview.chromium.org/916153002/diff/1/runtime/lib/typed_data.dart#...
runtime/lib/typed_data.dart:3593: if (cid == ClassID.cidSmi || cid ==
ClassID.cidMint) {
On 2015/02/11 20:40:06, srdjan wrote:
> Please add parentheses.
> Maybe instead of two tests you could only do:
> 
> return (cid == ClassID.cidBigint) ? _toInt(value, 0xFFFFFFFFFFFFFFFF) : value;

Done.

https://codereview.chromium.org/916153002/diff/1/runtime/lib/typed_data.dart#...
runtime/lib/typed_data.dart:3603: if (cid == ClassID.cidSmi || cid ==
ClassID.cidMint) {
On 2015/02/11 20:40:06, srdjan wrote:
> ditto

Done.

[regis, 2015-02-11 20:57:40]

Committed patchset #2 (id:20001) manually as r43697 (presubmit successful).