runtime/lib/typed_data.dart - Issue 916153002: Improve _toInt64() and _toUint64() conversions in TypedData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/typed_data.dart

Issue 916153002: Improve _toInt64() and _toUint64() conversions in TypedData. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/typed_data.dart

===================================================================

--- runtime/lib/typed_data.dart (revision 43696)

+++ runtime/lib/typed_data.dart (working copy)

@@ -3588,12 +3588,16 @@

int _toInt64(int value) {

- return _toInt(value, 0xFFFFFFFFFFFFFFFF); // TODO(regis): Avoid bigint mask.

+ // Avoid bigint mask when possible.

+ return (ClassID.getID(value) == ClassID.cidBigint) ?

+ _toInt(value, 0xFFFFFFFFFFFFFFFF) : value;

}

int _toUint64(int value) {

- return value & 0xFFFFFFFFFFFFFFFF; // TODO(regis): Avoid bigint mask.

+ // Avoid bigint mask when possible.

+ return (ClassID.getID(value) == ClassID.cidBigint) ?

+ _toInt(value, 0xFFFFFFFFFFFFFFFF) : value;

}

« no previous file with comments | « runtime/lib/bigint.dart ('k') | runtime/vm/object.cc » ('j') | no next file with comments »