Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 915523004: Fix timeout in test (Closed)

Created:
5 years, 10 months ago by Søren Gjesse
Modified:
5 years, 10 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix timeout in test The server socket could be closed before all connections was handled causing fewer calls to asyncEnd than to asyncStart and timeout. Now the test waits with closing the server socket until all expected connections have been made. R=kustermann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43647

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M tests/standalone/io/socket_source_address_test.dart View 1 4 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Søren Gjesse
5 years, 10 months ago (2015-02-10 14:13:25 UTC) #1
kustermann
LGTM https://codereview.chromium.org/915523004/diff/1/tests/standalone/io/socket_source_address_test.dart File tests/standalone/io/socket_source_address_test.dart (right): https://codereview.chromium.org/915523004/diff/1/tests/standalone/io/socket_source_address_test.dart#newcode126 tests/standalone/io/socket_source_address_test.dart:126: server.close(); -> await server.close() ?
5 years, 10 months ago (2015-02-10 14:20:17 UTC) #2
Søren Gjesse
https://codereview.chromium.org/915523004/diff/1/tests/standalone/io/socket_source_address_test.dart File tests/standalone/io/socket_source_address_test.dart (right): https://codereview.chromium.org/915523004/diff/1/tests/standalone/io/socket_source_address_test.dart#newcode126 tests/standalone/io/socket_source_address_test.dart:126: server.close(); On 2015/02/10 14:20:17, kustermann wrote: > -> await ...
5 years, 10 months ago (2015-02-10 14:29:10 UTC) #4
Søren Gjesse
5 years, 10 months ago (2015-02-10 14:29:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43647 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698