Fix timeout in test

tests/standalone/io/socket_source_address_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 
 import "dart:async";
 import "dart:io";
 
 import "package:async_helper/async_helper.dart";
 import "package:expect/expect.dart";
@@ skipping 52 matching lines @@
 // IPv6 addresses to use as source address when connecting locally.
 var ipV6SourceAddresses = [InternetAddress.LOOPBACK_IP_V6,
                            InternetAddress.ANY_IP_V6,
                            '::1',
                            '::'];
 
 Future testConnect(InternetAddress bindAddress,
                    bool v6Only,
                    Function connectFunction,
                    Function closeDestroyFunction) async {
+  var successCount = 0;
+  if (!v6Only) successCount += ipV4SourceAddresses.length;
+  if (bindAddress.type == InternetAddressType.IP_V6) {
+     successCount += ipV6SourceAddresses.length;
+  }
+  var count = 0;
+  var allConnected = new Completer();
+  if (successCount == 0) allConnected.complete();
+
   asyncStart();
   var server = await ServerSocket.bind(bindAddress, 0, v6Only: v6Only);
   server.listen((s) {
     s.destroy();
-    asyncEnd();
+    count++;
+    if (count == successCount) allConnected.complete();
   }, onDone: () => asyncEnd());
 
   asyncStart();
 
   // Connect with IPv4 source addesses.
   for (var sourceAddress in ipV4SourceAddresses) {
     if (!v6Only) {
-      asyncStart();  // Matching asyncEnd in server.listen above.
       var s = await connectFunction(InternetAddress.LOOPBACK_IP_V4,
                                    server.port,
                                    sourceAddress: sourceAddress);
       closeDestroyFunction(s);
     } else {
       // Cannot use an IPv6 source address to connect to IPv6 if
       // v6Only is specified.
       await throws(() => connectFunction(InternetAddress.LOOPBACK_IP_V4,
                                          server.port,
                                          sourceAddress: sourceAddress),
                    (e) => e is SocketException);
     }
   }
 
   // Connect with IPv6 source addesses.
   for (var sourceAddress in ipV6SourceAddresses) {
     if (bindAddress.type == InternetAddressType.IP_V6) {
-      asyncStart();  // Matching asyncEnd in server.listen above.
       var s = await connectFunction(InternetAddress.LOOPBACK_IP_V6,
                                     server.port,
                                     sourceAddress: sourceAddress);
       closeDestroyFunction(s);
     } else {
       // Cannot use an IPv6 source address to connect to IPv4.
       await throws(() => connectFunction(InternetAddress.LOOPBACK_IP_V6,
                                          server.port,
                                          sourceAddress: sourceAddress),
                    (e) => e is SocketException);
     }
   }
 
+  await allConnected.future;
   server.close();

[kustermann, 2015/02/10 14:20:17]

-> await server.close() ?

[Søren Gjesse, 2015/02/10 14:29:10]

Done.

   asyncEnd();
 }
 
 main() {
   testArguments(RawSocket.connect);
   testArguments(Socket.connect);
   testConnect(
       InternetAddress.ANY_IP_V4, false, RawSocket.connect, (s) => s.close());
   testConnect(
       InternetAddress.ANY_IP_V4, false, Socket.connect, (s) => s.destroy());
   testConnect(
       InternetAddress.ANY_IP_V6, false, RawSocket.connect, (s) => s.close());
   testConnect(
       InternetAddress.ANY_IP_V6, false, Socket.connect, (s) => s.destroy());
   testConnect(
       InternetAddress.ANY_IP_V6, true, RawSocket.connect, (s) => s.close());
   testConnect(
       InternetAddress.ANY_IP_V6, true, Socket.connect, (s) => s.destroy());
 }