Issue 915093005: Fix flaky disassembler crashes: do not call FindObject while concurrently sweeping.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 915093005: Fix flaky disassembler crashes: do not call FindObject while concurrently sweeping. (Closed)

Created:
5 years, 10 months ago by koda

Modified:
5 years, 10 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix flaky disassembler crashes: do not call FindOldObject while concurrently sweeping. The ia32 and x64 disassemblers call FindOldObject when trying to interpret addresses in the code. It's not safe to walk a heap page while it's being swept. BUG=dart:22087 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=43729

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	runtime/vm/heap.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

koda

5 years, 10 months ago (2015-02-12 17:18:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r43729 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages