Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: runtime/vm/heap.cc

Issue 915093005: Fix flaky disassembler crashes: do not call FindObject while concurrently sweeping. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/heap.cc
===================================================================
--- runtime/vm/heap.cc (revision 43676)
+++ runtime/vm/heap.cc (working copy)
@@ -253,6 +253,11 @@
RawObject* Heap::FindOldObject(FindObjectVisitor* visitor) const {
+ // Wait for any concurrent GC tasks to finish before walking.
+ MonitorLocker ml(old_space_->tasks_lock());
+ while (old_space_->tasks() > 0) {
+ ml.Wait();
+ }
return old_space_->FindObject(visitor, HeapPage::kData);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698