Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1563)

Issue 909603003: Include environment overrides when building repro command. (Closed)

Created:
5 years, 10 months ago by koda
Modified:
5 years, 10 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Include environment overrides when building repro command. This is important since flags to the Dart VM are passed through an environment variable. R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=43765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/testing/dart/test_runner.dart View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
5 years, 10 months ago (2015-02-06 22:24:00 UTC) #1
Bill Hesse
lgtm
5 years, 10 months ago (2015-02-13 09:46:09 UTC) #2
koda
5 years, 10 months ago (2015-02-13 15:41:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r43765 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698