Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 909603003: Include environment overrides when building repro command. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 43572)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -128,12 +128,17 @@
deepJsonCompare(environmentOverrides, other.environmentOverrides);
String get reproductionCommand {
+ var env = new StringBuffer();
+ environmentOverrides.forEach((key, value) =>
+ (io.Platform.operatingSystem == 'windows') ?
+ env.write('set $key=${escapeCommandLineArgument(value)} & ') :
+ env.write('$key=${escapeCommandLineArgument(value)} '));
var command = ([executable]..addAll(arguments))
.map(escapeCommandLineArgument).join(' ');
if (workingDirectory != null) {
command = "$command (working directory: $workingDirectory)";
}
- return command;
+ return "$env$command";
}
Future<bool> get outputIsUpToDate => new Future.value(false);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698