Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 909483003: cps2js: Bugfix in named parameters in call to superconstructor. (Closed)

Created:
5 years, 10 months ago by asgerf
Modified:
5 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

cps2js: Bugfix in named parameters in call to superconstructor. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=43633

Patch Set 1 #

Patch Set 2 : Test case #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_constructor_test.dart View 1 1 chunk +31 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (1 generated)
asgerf
5 years, 10 months ago (2015-02-06 15:16:42 UTC) #2
asgerf
Ping. Or should I move this into the other CL?
5 years, 10 months ago (2015-02-10 09:45:42 UTC) #3
karlklose
Sorry, did not see the mail. Could you add a test?
5 years, 10 months ago (2015-02-10 09:56:52 UTC) #4
asgerf
On 2015/02/10 09:56:52, karlklose wrote: > Sorry, did not see the mail. > > Could ...
5 years, 10 months ago (2015-02-10 10:14:59 UTC) #5
asgerf
https://codereview.chromium.org/909483003/diff/20001/tests/compiler/dart2js/js_backend_cps_ir_constructor_test.dart File tests/compiler/dart2js/js_backend_cps_ir_constructor_test.dart (right): https://codereview.chromium.org/909483003/diff/20001/tests/compiler/dart2js/js_backend_cps_ir_constructor_test.dart#newcode169 tests/compiler/dart2js/js_backend_cps_ir_constructor_test.dart:169: v0.Bar$5$q$w$y$z(x, q, w, y, z); This is the change ...
5 years, 10 months ago (2015-02-10 10:21:17 UTC) #6
karlklose
LGTM.
5 years, 10 months ago (2015-02-10 10:30:15 UTC) #7
asgerf
5 years, 10 months ago (2015-02-10 10:31:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43633 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698