Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart

Issue 909483003: cps2js: Bugfix in named parameters in call to superconstructor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Test case Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart
index 9eafea621fd7bd0b0c18106d0f53e1747687240e..e3a146d8e63c3a75177c0ab8bbf5e6f0494243a7 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart
@@ -1408,8 +1408,9 @@ class JsIrBuilderVisitor extends IrBuilderVisitor {
ir.Primitive value;
// Load argument if provided.
if (signature.optionalParametersAreNamed) {
- int translatedIndex = selector.namedArguments.indexOf(param.name);
- if (translatedIndex != -1) {
+ int nameIndex = selector.namedArguments.indexOf(param.name);
+ if (nameIndex != -1) {
+ int translatedIndex = selector.positionalArgumentCount + nameIndex;
value = arguments[translatedIndex];
}
} else if (index < arguments.length) {
@@ -1418,7 +1419,7 @@ class JsIrBuilderVisitor extends IrBuilderVisitor {
// Load default if argument was not provided.
if (value == null) {
if (param.initializer != null) {
- value = visit(param.initializer);
+ value = inlineExpression(target, param.initializer);
} else {
value = irBuilder.buildNullLiteral();
}

Powered by Google App Engine
This is Rietveld 408576698