Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 908493003: filter static methods when showing instance completions (Closed)

Created:
5 years, 10 months ago by danrubel
Modified:
5 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

filter static methods when showing instance completions BUG=dartbug.com/22171 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43580

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -31 lines) Patch
M pkg/analysis_server/lib/src/services/completion/invocation_computer.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 1 chunk +12 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 4 chunks +4 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/invocation_computer_test.dart View 2 chunks +86 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years, 10 months ago (2015-02-06 22:38:57 UTC) #2
scheglov
LGTM
5 years, 10 months ago (2015-02-06 23:03:03 UTC) #3
danrubel
5 years, 10 months ago (2015-02-07 00:56:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43580 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698