Issue 908183002: Implement mac support for having multiple Dart_Port's registered on one OS socket

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 908183002: Implement mac support for having multiple Dart_Port's registered on one OS socket (Closed)

Created:
5 years, 10 months ago by kustermann

Modified:
5 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Implement mac support for having multiple Dart_Port's registered on one OS socket R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=43632

Patch Set 3 : Disable token count > 0 assert in eventhandler.h #

Patch Set 4 : Rebased #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -113 lines)			Patch
M	runtime/bin/eventhandler.h	View	1 2 3	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/bin/eventhandler_android.cc	View	1	1 chunk	+4 lines, -7 lines	0 comments	Download
M	runtime/bin/eventhandler_linux.cc	View	1	1 chunk	+4 lines, -7 lines	0 comments	Download
M	runtime/bin/eventhandler_macos.h	View		3 chunks	+35 lines, -39 lines	0 comments	Download
M	runtime/bin/eventhandler_macos.cc	View	1	8 chunks	+116 lines, -58 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Søren Gjesse

lgtm https://codereview.chromium.org/908183002/diff/20001/runtime/bin/eventhandler_macos.cc File runtime/bin/eventhandler_macos.cc (right): https://codereview.chromium.org/908183002/diff/20001/runtime/bin/eventhandler_macos.cc#newcode254 runtime/bin/eventhandler_macos.cc:254: Empty lines

5 years, 10 months ago (2015-02-10 09:17:15 UTC) #3

kustermann

5 years, 10 months ago (2015-02-10 10:15:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as 43632 (presubmit successful).