Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: runtime/bin/eventhandler_macos.h

Issue 908183002: Implement mac support for having multiple Dart_Port's registered on one OS socket (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebased Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/eventhandler_linux.cc ('k') | runtime/bin/eventhandler_macos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/eventhandler_macos.h
diff --git a/runtime/bin/eventhandler_macos.h b/runtime/bin/eventhandler_macos.h
index ebfe251b35718cf228d15042a55fff179ede5840..391ca3d5e139a845979801fa5474127240966b86 100644
--- a/runtime/bin/eventhandler_macos.h
+++ b/runtime/bin/eventhandler_macos.h
@@ -21,56 +21,50 @@
namespace dart {
namespace bin {
-class SocketData {
+class DescriptorInfo : public DescriptorInfoBase {
public:
- explicit SocketData(intptr_t fd, bool is_listening)
- : fd_(fd),
- port_(0),
- mask_(0),
- tracked_by_kqueue_(false),
- tokens_(16),
- is_listening_(is_listening) {
- ASSERT(fd_ != -1);
- }
+ explicit DescriptorInfo(intptr_t fd)
+ : DescriptorInfoBase(fd), tracked_by_kqueue_(false) { }
- bool HasReadEvent();
- bool HasWriteEvent();
+ virtual ~DescriptorInfo() { }
- bool IsListeningSocket() { return is_listening_; }
+ intptr_t GetPollEvents();
- void SetPortAndMask(Dart_Port port, intptr_t mask) {
- ASSERT(fd_ != -1);
- port_ = port;
- mask_ = mask;
+ virtual void Close() {
+ VOID_TEMP_FAILURE_RETRY(close(fd_));
+ fd_ = -1;
}
- intptr_t fd() { return fd_; }
- Dart_Port port() { return port_; }
- intptr_t mask() { return mask_; }
- bool tracked_by_kqueue() { return tracked_by_kqueue_; }
void set_tracked_by_kqueue(bool value) {
tracked_by_kqueue_ = value;
}
- // Returns true if the last token was taken.
- bool TakeToken() {
- tokens_--;
- return tokens_ == 0;
- }
+ bool tracked_by_kqueue() { return tracked_by_kqueue_; }
- // Returns true if the tokens was 0 before adding.
- bool ReturnToken() {
- tokens_++;
- return tokens_ == 1;
- }
+ bool HasReadEvent();
- private:
- intptr_t fd_;
- Dart_Port port_;
- intptr_t mask_;
+ bool HasWriteEvent();
+
+ protected:
bool tracked_by_kqueue_;
- int tokens_;
- bool is_listening_;
+};
+
+
+class DescriptorInfoSingle
+ : public DescriptorInfoSingleMixin<DescriptorInfo> {
+ public:
+ explicit DescriptorInfoSingle(intptr_t fd)
+ : DescriptorInfoSingleMixin(fd) {}
+ virtual ~DescriptorInfoSingle() {}
+};
+
+
+class DescriptorInfoMultiple
+ : public DescriptorInfoMultipleMixin<DescriptorInfo> {
+ public:
+ explicit DescriptorInfoMultiple(intptr_t fd)
+ : DescriptorInfoMultipleMixin(fd) {}
+ virtual ~DescriptorInfoMultiple() {}
};
@@ -79,9 +73,11 @@ class EventHandlerImplementation {
EventHandlerImplementation();
~EventHandlerImplementation();
+ void UpdateKQueueInstance(intptr_t old_mask, DescriptorInfo *di);
+
// Gets the socket data structure for a given file
// descriptor. Creates a new one if one is not found.
- SocketData* GetSocketData(intptr_t fd, bool is_listening);
+ DescriptorInfo* GetDescriptorInfo(intptr_t fd, bool is_listening);
void SendData(intptr_t id, Dart_Port dart_port, int64_t data);
void Start(EventHandler* handler);
void Shutdown();
@@ -94,7 +90,7 @@ class EventHandlerImplementation {
void WakeupHandler(intptr_t id, Dart_Port dart_port, int64_t data);
void HandleInterruptFd();
void SetPort(intptr_t fd, Dart_Port dart_port, intptr_t mask);
- intptr_t GetEvents(struct kevent* event, SocketData* sd);
+ intptr_t GetEvents(struct kevent* event, DescriptorInfo* di);
static void* GetHashmapKeyFromFd(intptr_t fd);
static uint32_t GetHashmapHashFromFd(intptr_t fd);
« no previous file with comments | « runtime/bin/eventhandler_linux.cc ('k') | runtime/bin/eventhandler_macos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698