Remove SetNonBlocking/SetBlocking methods from Socket and add missing close-on-exec

Remove SetNonBlocking/SetBlocking methods from Socket and add missing close-on-exec

The methods SetNonBlocking/SetBlocking on Sockets where not implemented on Linux
and not used on Windwsm. Removed and call directly to FDUtils when needed.

In Socket::Accept setting close on exec was missing on OS X and Android.

R=kustermann@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=43627

[kustermann, 2015-02-09 16:25:32]

lgtm

https://codereview.chromium.org/907883002/diff/1/runtime/bin/socket_android.cc
File runtime/bin/socket_android.cc (right):

https://codereview.chromium.org/907883002/diff/1/runtime/bin/socket_android.c...
runtime/bin/socket_android.cc:404: FDUtils::SetCloseOnExec(socket);
I'd reverse the order.

https://codereview.chromium.org/907883002/diff/1/runtime/bin/socket_macos.cc
File runtime/bin/socket_macos.cc (right):

https://codereview.chromium.org/907883002/diff/1/runtime/bin/socket_macos.cc#...
runtime/bin/socket_macos.cc:427: FDUtils::SetCloseOnExec(socket);
ditto.

[Søren Gjesse, 2015-02-10 07:28:15]

https://codereview.chromium.org/907883002/diff/1/runtime/bin/socket_android.cc
File runtime/bin/socket_android.cc (right):

https://codereview.chromium.org/907883002/diff/1/runtime/bin/socket_android.c...
runtime/bin/socket_android.cc:404: FDUtils::SetCloseOnExec(socket);
On 2015/02/09 16:25:32, kustermann wrote:
> I'd reverse the order.

Done.

https://codereview.chromium.org/907883002/diff/1/runtime/bin/socket_macos.cc
File runtime/bin/socket_macos.cc (right):

https://codereview.chromium.org/907883002/diff/1/runtime/bin/socket_macos.cc#...
runtime/bin/socket_macos.cc:427: FDUtils::SetCloseOnExec(socket);
On 2015/02/09 16:25:32, kustermann wrote:
> ditto.

Done.

[Søren Gjesse, 2015-02-10 07:29:17]

New patchsets have been uploaded after l-g-t-m from kustermann@google.com

[Søren Gjesse, 2015-02-10 07:30:24]

Committed patchset #2 (id:20001) manually as 43627.