runtime/bin/socket_linux.cc - Issue 907883002: Remove SetNonBlocking/SetBlocking methods from Socket and add missing close-on-exec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket_linux.cc

Issue 907883002: Remove SetNonBlocking/SetBlocking methods from Socket and add missing close-on-exec (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/socket_linux.cc

diff --git a/runtime/bin/socket_linux.cc b/runtime/bin/socket_linux.cc

index c6e1fe1a885298ce14ab11e6416deb64d4c82ecd..87df8ff51047241b4724aa098fb9957f048d994d 100644

--- a/runtime/bin/socket_linux.cc

+++ b/runtime/bin/socket_linux.cc

@@ -427,8 +427,8 @@ intptr_t ServerSocket::Accept(intptr_t fd) {

socket = kTemporaryFailure;

}

} else {

- FDUtils::SetNonBlocking(socket);

FDUtils::SetCloseOnExec(socket);

+ FDUtils::SetNonBlocking(socket);

}

return socket;

}

« no previous file with comments | « runtime/bin/socket_android.cc ('k') | runtime/bin/socket_macos.cc » ('j') | no next file with comments »