Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 905293003: Fix inference of the static type of an async function literal. (Closed)

Created:
5 years, 10 months ago by Paul Berry
Modified:
5 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix inference of the static type of an async function literal. This implements the spec change currently under review here: https://codereview.chromium.org/902703003 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43613

Patch Set 1 #

Patch Set 2 : Fix incorrect comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 2 chunks +65 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 10 months ago (2015-02-09 20:32:12 UTC) #2
scheglov
LGTM
5 years, 10 months ago (2015-02-09 20:39:37 UTC) #3
Paul Berry
5 years, 10 months ago (2015-02-09 21:21:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43613 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698