Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 902703003: Correct return types for async function expresssions. (Closed)

Created:
5 years, 10 months ago by gbracha
Modified:
5 years, 9 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Correct return types for async function expresssions.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M docs/language/dartLangSpec.tex View 1 2 3 chunks +8 lines, -8 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
gbracha
5 years, 10 months ago (2015-02-05 23:25:11 UTC) #2
Paul Berry
lgtm, however you might want to consider: - Including a reference to the section in ...
5 years, 10 months ago (2015-02-05 23:35:35 UTC) #3
gbracha
On 2015/02/05 23:35:35, Paul Berry wrote: > lgtm, however you might want to consider: > ...
5 years, 10 months ago (2015-02-05 23:41:25 UTC) #5
Paul Berry
5 years, 10 months ago (2015-02-05 23:56:07 UTC) #6
lgtm with one minor nit.

https://codereview.chromium.org/902703003/diff/40001/docs/language/dartLangSp...
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/902703003/diff/40001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:5742: It is a static type warning if the body of
$f$ is marked \ASYNC{} and the type \code{Future$<$flatten(T)$>$}
(\ref{awaitExpressions}) may not be assigned to the declared return type of $f$.
  Otherwise, it is a static type warning if $T$ may not be assigned to the
declared return type of $f$.
This reference needs to be updated to point to \ref{functionExpressions}.

Powered by Google App Engine
This is Rietveld 408576698