Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 904763003: Redesign inlining interval computation. (Closed)

Created:
5 years, 10 months ago by srdjan
Modified:
5 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Redesign inlining interval computation. Committed: https://code.google.com/p/dart/source/detail?r=43622

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 6

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -114 lines) Patch
M runtime/vm/compiler.cc View 1 2 3 4 5 8 chunks +18 lines, -5 lines 0 comments Download
M runtime/vm/disassembler.cc View 1 2 3 4 5 1 chunk +11 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph.h View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 2 3 4 5 3 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 3 4 5 7 chunks +70 lines, -57 lines 0 comments Download
M runtime/vm/flow_graph_inliner.h View 1 2 3 4 5 2 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 2 3 4 5 16 chunks +54 lines, -25 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 3 chunks +11 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 4 chunks +62 lines, -12 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
Fix for issue: 22255
5 years, 10 months ago (2015-02-05 23:51:24 UTC) #2
Cutch
LGTMwC https://codereview.chromium.org/904763003/diff/80001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/904763003/diff/80001/runtime/vm/compiler.cc#newcode36 runtime/vm/compiler.cc:36: #include "vm/service.h" Is this needed? https://codereview.chromium.org/904763003/diff/80001/runtime/vm/flow_graph_inliner.cc File runtime/vm/flow_graph_inliner.cc ...
5 years, 10 months ago (2015-02-09 20:48:23 UTC) #3
srdjan
https://codereview.chromium.org/904763003/diff/80001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/904763003/diff/80001/runtime/vm/compiler.cc#newcode36 runtime/vm/compiler.cc:36: #include "vm/service.h" On 2015/02/09 20:48:23, Cutch wrote: > Is ...
5 years, 10 months ago (2015-02-09 23:05:03 UTC) #4
srdjan
5 years, 10 months ago (2015-02-09 23:11:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as r43622 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698