Redesign inlining interval computation.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 12155 matching lines @@
   StorePointer(&raw_ptr()->comments_, comments.comments_.raw());
 }
 
 
 void Code::set_inlined_intervals(const Array& value) const {
   ASSERT(value.IsOld());
   StorePointer(&raw_ptr()->inlined_intervals_, value.raw());
 }
 
 
+void Code::set_inlined_id_to_function(const Array& value) const {
+  ASSERT(value.IsOld());
+  StorePointer(&raw_ptr()->inlined_id_to_function_, value.raw());
+}
+
+
 RawCode* Code::New(intptr_t pointer_offsets_length) {
   if (pointer_offsets_length < 0 || pointer_offsets_length > kMaxElements) {
     // This should be caught before we reach here.
     FATAL1("Fatal error in Code::New: invalid pointer_offsets_length %" Pd "\n",
            pointer_offsets_length);
   }
   ASSERT(Object::code_class() != Class::null());
   Code& result = Code::Handle();
   {
     uword size = Code::InstanceSize(pointer_offsets_length);
@@ skipping 333 matching lines @@
     if (map->PcOffset() == pc_offset) {
       return map->raw();  // We found a stack map for this frame.
     }
   }
   // If the code has stackmaps, it must have them for all safepoints.
   UNREACHABLE();
   return Stackmap::null();
 }
 
 
+intptr_t Code::GetCallerId(intptr_t inlined_id) const {
+  if (inlined_id < 0) return -1;
+  const Array& intervals = Array::Handle(inlined_intervals());
+  Smi& temp_smi = Smi::Handle();
+  for (intptr_t i = 0; i < intervals.Length() - Code::kInlIntNumEntries;
+       i += Code::kInlIntNumEntries) {
+    temp_smi ^= intervals.At(i + Code::kInlIntInliningId);
+    if (temp_smi.Value() == inlined_id) {
+      temp_smi ^= intervals.At(i + Code::kInlIntCallerId);
+      return temp_smi.Value();
+    }
+  }
+  return -1;
+}
+
+
 void Code::GetInlinedFunctionsAt(
     intptr_t offset, GrowableArray<Function*>* fs) const {
   fs->Clear();
   const Array& intervals = Array::Handle(inlined_intervals());
   if (intervals.IsNull()) {
     // E.g., for code stubs.
     return;
   }
+  // First find the right interval. TODO(srdjan): use binary search since
+  // intervals are sorted.
   Smi& start = Smi::Handle();
   Smi& end = Smi::Handle();
-  Function& function = Function::Handle();
-  for (intptr_t i = 0; i < intervals.Length(); i += Code::kInlIntNumEntries) {
+  intptr_t found_interval_ix = 0;

[Cutch, 2015/02/09 20:48:23]

How about:

intptr_t found_interval_ix = -1;

and then after the loop:

ASSERT(found_interval_ix != -1);

[srdjan, 2015/02/09 23:05:03]

This does not work for code with a single interval. Changed:

Initialize: found_interval_ix = intervals.Length() - Code::kInlIntNumEntries;
set it at break.

+  for (intptr_t i = 0; i < intervals.Length() - Code::kInlIntNumEntries;
+       i += Code::kInlIntNumEntries) {
+    found_interval_ix = i;
     start ^= intervals.At(i + Code::kInlIntStart);
     if (!start.IsNull()) {
-      end ^= intervals.At(i + Code::kInlIntEnd);
+      end ^= intervals.At(i + Code::kInlIntNumEntries + Code::kInlIntStart);
       if ((start.Value() <= offset) && (offset < end.Value())) {
-        function ^= intervals.At(i + Code::kInlIntFunction);
-        fs->Add(&Function::ZoneHandle(function.raw()));
+        break;
       }
     }
   }
+
+  // Find all functions.
+  const Array& id_map = Array::Handle(inlined_id_to_function());
+  Smi& temp_smi = Smi::Handle();
+  temp_smi ^= intervals.At(found_interval_ix + Code::kInlIntInliningId);
+  intptr_t inlining_id = temp_smi.Value();
+  ASSERT(inlining_id >= 0);
+  temp_smi ^= intervals.At(found_interval_ix + Code::kInlIntCallerId);
+  intptr_t caller_id = temp_smi.Value();
+  while (inlining_id >= 0) {
+    Function& function = Function::ZoneHandle();
+    function  ^= id_map.At(inlining_id);
+    fs->Add(&function);
+    inlining_id = caller_id;
+    caller_id = GetCallerId(inlining_id);
+  }
 }
 
 
 void Code::DumpInlinedIntervals() const {
   OS::Print("Inlined intervals:\n");
   const Array& intervals = Array::Handle(inlined_intervals());
   Smi& start = Smi::Handle();
-  Smi& end = Smi::Handle();
-  Function& function = Function::Handle();
+  Smi& inlining_id = Smi::Handle();
+  Smi& caller_id = Smi::Handle();
   for (intptr_t i = 0; i < intervals.Length(); i += Code::kInlIntNumEntries) {
     start ^= intervals.At(i + Code::kInlIntStart);
-    if (!start.IsNull()) {
-      end ^= intervals.At(i + Code::kInlIntEnd);
-      function ^= intervals.At(i + Code::kInlIntFunction);
-      OS::Print("%" Pd " .. %" Pd " %s\n",
-          start.Value(), end.Value(), function.ToQualifiedCString());
+    ASSERT(!start.IsNull());
+    if (start.IsNull()) continue;
+    inlining_id ^= intervals.At(i + Code::kInlIntInliningId);
+    caller_id ^= intervals.At(i + Code::kInlIntCallerId);
+    OS::Print("  %" Px " id: %" Pd " caller-id: %" Pd " \n",
+        start.Value(), inlining_id.Value(), caller_id.Value());
+  }
+  OS::Print("Inlined ids:\n");
+  const Array& id_map = Array::Handle(inlined_id_to_function());
+  Function& function = Function::Handle();
+  for (intptr_t i = 0; i < id_map.Length(); i++) {
+    function ^= id_map.At(i);
+    if (!function.IsNull()) {
+      OS::Print("  %" Pd ": %s\n", i, function.ToQualifiedCString());
     }
   }
 }
 
 
 RawContext* Context::New(intptr_t num_variables, Heap::Space space) {
   ASSERT(num_variables >= 0);
   ASSERT(Object::context_class() != Class::null());
 
   if (num_variables < 0 || num_variables > kMaxElements) {
@@ skipping 7990 matching lines @@
   return tag_label.ToCString();
 }
 
 
 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
   Instance::PrintJSONImpl(stream, ref);
 }
 
 
 }  // namespace dart