Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 904093002: Discard pending notifications on the same source change. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Discard pending notifications on the same source change. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43564

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -112 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +17 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation.dart View 2 chunks +14 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 7 chunks +29 lines, -12 lines 1 comment Download
M pkg/analysis_server/lib/src/operation/operation_queue.dart View 4 chunks +32 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/update_content_test.dart View 2 chunks +33 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/operation/operation_queue_test.dart View 3 chunks +136 lines, -98 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 10 months ago (2015-02-06 19:13:58 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/904093002/diff/1/pkg/analysis_server/lib/src/operation/operation_analysis.dart File pkg/analysis_server/lib/src/operation/operation_analysis.dart (right): https://codereview.chromium.org/904093002/diff/1/pkg/analysis_server/lib/src/operation/operation_analysis.dart#newcode343 pkg/analysis_server/lib/src/operation/operation_analysis.dart:343: bool shouldBeDiscardedOnSourceChange(Source source) { This method duplicates the ...
5 years, 10 months ago (2015-02-06 19:24:17 UTC) #2
scheglov
5 years, 10 months ago (2015-02-06 19:31:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43564 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698