Discard pending notifications on the same source change.

pkg/analysis_server/lib/src/operation/operation_analysis.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library operation.analysis;
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/computer/computer_highlights.dart';
 import 'package:analysis_server/src/computer/computer_navigation.dart';
 import 'package:analysis_server/src/computer/computer_occurrences.dart';
@@ skipping 246 matching lines @@
     options.cacheSize = cacheSize;
     context.analysisOptions = options;
   }
 
   void _updateIndex(AnalysisServer server, List<ChangeNotice> notices) {
     Index index = server.index;
     if (index == null) {
       return;
     }
     for (ChangeNotice notice in notices) {
+      String file = notice.source.fullName;
       // Dart
       try {
         CompilationUnit dartUnit = notice.resolvedDartUnit;
         if (dartUnit != null) {
-          server.addOperation(new _DartIndexOperation(context, dartUnit));
+          server.addOperation(new _DartIndexOperation(context, file, dartUnit));
         }
       } catch (exception, stackTrace) {
         server.sendServerErrorNotification(exception, stackTrace);
       }
       // HTML
       try {
         HtmlUnit htmlUnit = notice.resolvedHtmlUnit;
         if (htmlUnit != null) {
-          server.addOperation(new _HtmlIndexOperation(context, htmlUnit));
+          server.addOperation(new _HtmlIndexOperation(context, file, htmlUnit));
         }
       } catch (exception, stackTrace) {
         server.sendServerErrorNotification(exception, stackTrace);
       }
     }
   }
 }
 
 
 class _DartHighlightsOperation extends _DartNotificationOperation {
   _DartHighlightsOperation(String file, CompilationUnit unit)
       : super(file, unit);
 
   @override
   void perform(AnalysisServer server) {
     sendAnalysisNotificationHighlights(server, file, unit);
   }
 }
 
 
-class _DartIndexOperation extends ServerOperation {
+class _DartIndexOperation extends _SingleFileOperation {
   final AnalysisContext context;
   final CompilationUnit unit;
 
-  _DartIndexOperation(this.context, this.unit);
+  _DartIndexOperation(this.context, String file, this.unit) : super(file);
 
   @override
   ServerOperationPriority get priority {
     return ServerOperationPriority.ANALYSIS_INDEX;
   }
 
   @override
   void perform(AnalysisServer server) {
     Index index = server.index;
     index.indexUnit(context, unit);
   }
 }
 
 
 class _DartNavigationOperation extends _DartNotificationOperation {
   _DartNavigationOperation(String file, CompilationUnit unit)
       : super(file, unit);
 
   @override
   void perform(AnalysisServer server) {
     sendAnalysisNotificationNavigation(server, file, unit);
   }
 }
 
 
-abstract class _DartNotificationOperation extends ServerOperation {
-  final String file;
+abstract class _DartNotificationOperation extends _SingleFileOperation {
   final CompilationUnit unit;
 
-  _DartNotificationOperation(this.file, this.unit);
+  _DartNotificationOperation(String file, this.unit) : super(file);
 
   @override
   ServerOperationPriority get priority {
     return ServerOperationPriority.ANALYSIS_NOTIFICATION;
   }
+
+  @override
+  bool shouldBeDiscardedOnSourceChange(Source source) {

[Brian Wilkerson, 2015/02/06 19:24:17]

This method duplicates the inherited method and could be removed.

+    return source.fullName == file;
+  }
 }
 
 
 class _DartOccurrencesOperation extends _DartNotificationOperation {
   _DartOccurrencesOperation(String file, CompilationUnit unit)
       : super(file, unit);
 
   @override
   void perform(AnalysisServer server) {
     sendAnalysisNotificationOccurrences(server, file, unit);
@@ skipping 18 matching lines @@
   _DartOverridesOperation(String file, CompilationUnit unit)
       : super(file, unit);
 
   @override
   void perform(AnalysisServer server) {
     sendAnalysisNotificationOverrides(server, file, unit);
   }
 }
 
 
-class _HtmlIndexOperation extends ServerOperation {
+class _HtmlIndexOperation extends _SingleFileOperation {
   final AnalysisContext context;
   final HtmlUnit unit;
 
-  _HtmlIndexOperation(this.context, this.unit);
+  _HtmlIndexOperation(this.context, String file, this.unit) : super(file);
 
   @override
   ServerOperationPriority get priority {
     return ServerOperationPriority.ANALYSIS_INDEX;
   }
 
   @override
   void perform(AnalysisServer server) {
     Index index = server.index;
     index.indexHtmlUnit(context, unit);
   }
 }
 
 
-class _NotificationErrorsOperation extends ServerOperation {
-  final String file;
+class _NotificationErrorsOperation extends _SingleFileOperation {
   final LineInfo lineInfo;
   final List<AnalysisError> errors;
 
-  _NotificationErrorsOperation(this.file, this.lineInfo, this.errors);
+  _NotificationErrorsOperation(String file, this.lineInfo, this.errors)
+      : super(file);
 
   @override
   ServerOperationPriority get priority {
     return ServerOperationPriority.ANALYSIS_NOTIFICATION;
   }
 
   @override
   void perform(AnalysisServer server) {
     sendAnalysisNotificationErrors(server, file, lineInfo, errors);
   }
 }
+
+
+abstract class _SingleFileOperation extends SourceSensitiveOperation {
+  final String file;
+
+  _SingleFileOperation(this.file);
+
+  @override
+  bool shouldBeDiscardedOnSourceChange(Source source) {
+    return source.fullName == file;
+  }
+}