Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 903563003: Add sourceMaps option to $dart2js transformer. (Closed)

Created:
5 years, 10 months ago by Chris Bracken
Modified:
5 years, 10 months ago
Reviewers:
Bob Nystrom, nweiz
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add sourceMaps option to $dart2js transformer. BUG=https://code.google.com/p/dart/issues/detail?id=22174 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=43536

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Renamed emitSourceMaps to sourceMaps, added more tests #

Patch Set 3 : Minor formatting #

Messages

Total messages: 7 (2 generated)
Chris Bracken
5 years, 10 months ago (2015-02-05 01:32:58 UTC) #3
nweiz
Please also test that this option enables source maps in release mode and disables them ...
5 years, 10 months ago (2015-02-05 22:15:00 UTC) #4
Chris Bracken
https://codereview.chromium.org/903563003/diff/20001/sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart File sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart (right): https://codereview.chromium.org/903563003/diff/20001/sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart#newcode28 sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:28: 'suppressPackageWarnings', 'terse', 'emitSourceMaps' On 2015/02/05 22:14:59, nweiz wrote: > ...
5 years, 10 months ago (2015-02-06 00:33:07 UTC) #5
nweiz
lgtm!
5 years, 10 months ago (2015-02-06 00:49:23 UTC) #6
Chris Bracken
5 years, 10 months ago (2015-02-06 01:02:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as 43536 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698