Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: sdk/lib/_internal/pub_generated/lib/src/barback/dart2js_transformer.dart

Issue 903563003: Add sourceMaps option to $dart2js transformer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Minor formatting Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub_generated/lib/src/barback/dart2js_transformer.dart
diff --git a/sdk/lib/_internal/pub_generated/lib/src/barback/dart2js_transformer.dart b/sdk/lib/_internal/pub_generated/lib/src/barback/dart2js_transformer.dart
index 3910ef8be56924bf5cc542e758c0fb7094c1a166..b6362eb5e3d1082d5ed4459cc1de0f5ee8b71058 100644
--- a/sdk/lib/_internal/pub_generated/lib/src/barback/dart2js_transformer.dart
+++ b/sdk/lib/_internal/pub_generated/lib/src/barback/dart2js_transformer.dart
@@ -33,7 +33,8 @@ final _validOptions = new Set<String>.from(
'suppressWarnings',
'suppressHints',
'suppressPackageWarnings',
- 'terse']);
+ 'terse',
+ 'sourceMaps']);
/// A [Transformer] that uses dart2js's library API to transform Dart
/// entrypoints in "web" to JavaScript.
@@ -49,7 +50,8 @@ class Dart2JSTransformer extends Transformer implements LazyTransformer {
final BarbackSettings _settings;
/// Whether source maps should be generated for the compiled JS.
- bool get _generateSourceMaps => _settings.mode != BarbackMode.RELEASE;
+ bool get _generateSourceMaps =>
+ _configBool('sourceMaps', defaultsTo: _settings.mode != BarbackMode.RELEASE);
Dart2JSTransformer.withSettings(this._environment, this._settings) {
var invalidOptions =
@@ -158,7 +160,7 @@ class Dart2JSTransformer extends Transformer implements LazyTransformer {
'suppressPackageWarnings',
defaultsTo: true),
terse: _configBool('terse'),
- includeSourceMapUrls: _settings.mode != BarbackMode.RELEASE);
+ includeSourceMapUrls: _generateSourceMaps);
}
/// Parses and returns the "commandLineOptions" configuration option.

Powered by Google App Engine
This is Rietveld 408576698