Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 901713004: Invalidate hints instead of computing them in the incremental resolver. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Invalidate hints instead of computing them in the incremental resolver. So, we don't need to prepare all the library parts before incremental resolution. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43526

Patch Set 1 #

Total comments: 2

Patch Set 2 : Invalidate hints for included parts too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -79 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 1 5 chunks +34 lines, -21 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 13 chunks +15 lines, -51 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 3 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
5 years, 10 months ago (2015-02-05 21:14:52 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/901713004/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/901713004/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode2259 pkg/analyzer/lib/src/generated/engine.dart:2259: void invalidateLibraryHints(Source librarySource) { This needs to iterate ...
5 years, 10 months ago (2015-02-05 21:55:59 UTC) #2
scheglov
https://codereview.chromium.org/901713004/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/901713004/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode2259 pkg/analyzer/lib/src/generated/engine.dart:2259: void invalidateLibraryHints(Source librarySource) { On 2015/02/05 21:55:59, Brian Wilkerson ...
5 years, 10 months ago (2015-02-05 22:06:27 UTC) #4
scheglov
5 years, 10 months ago (2015-02-05 22:06:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43526 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698