Invalidate hints instead of computing them in the incremental resolver.

pkg/analyzer/test/generated/incremental_resolver_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.incremental_resolver_test;
 
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/error.dart';
@@ skipping 2488 matching lines @@
     }
     // update tokens
     {
       int delta = edit.replacement.length - edit.length;
       _shiftTokens(unit.beginToken, offset, delta);
     }
     // do incremental resolution
     int updateOffset = edit.offset;
     int updateEndOld = updateOffset + edit.length;
     int updateOldNew = updateOffset + edit.replacement.length;
-    IncrementalResolver resolver =
-        new IncrementalResolver(<Source, CompilationUnit>{
-      source: newUnit
-    }, unit.element, updateOffset, updateEndOld, updateOldNew);
+    IncrementalResolver resolver = new IncrementalResolver(
+        unit.element,
+        updateOffset,
+        updateEndOld,
+        updateOldNew);
     bool success = resolver.resolve(newNode);
     expect(success, isTrue);
-    List<AnalysisError> newErrors = analysisContext.getErrors(source).errors;
+    List<AnalysisError> newErrors = analysisContext.computeErrors(source);
     // resolve "newCode" from scratch
     CompilationUnit fullNewUnit;
     {
       source = addSource(newCode);
       _runTasks();
       LibraryElement library = resolve(source);
       fullNewUnit = resolveCompilationUnit(source, library);
     }
     try {
       assertSameResolution(unit, fullNewUnit);
@@ skipping 678 matching lines @@
     _runTasks();
     // perform incremental resolution
     _resetWithIncremental(true);
     analysisContext2.setContents(partSource, r'''
 part of lib;
 
 f(A a) {
 //  a._foo();
 }
 ''');
+    // no hints right now, because we delay hints computing
+    {
+      List<AnalysisError> errors = analysisContext.getErrors(source).errors;
+      expect(errors, isEmpty);
+    }
     // a new hint should be added
-    List<AnalysisError> errors = analysisContext.getErrors(source).errors;
+    List<AnalysisError> errors = analysisContext.computeErrors(source);
     expect(errors, hasLength(1));
     expect(errors[0].errorCode.type, ErrorType.HINT);
     // the same hint should be reported using a ChangeNotice
     bool noticeFound = false;
     AnalysisResult result = analysisContext2.performAnalysisTask();
     for (ChangeNotice notice in result.changeNotices) {
       if (notice.source == source) {
         expect(notice.errors, contains(errors[0]));
         noticeFound = true;
       }
@@ skipping 225 matching lines @@
 
   void _updateAndValidate(String newCode, {bool expectedSuccess: true,
       bool compareWithFull: true}) {
     // Run any pending tasks tasks.
     _runTasks();
     // Update the source - currently this may cause incremental resolution.
     // Then request the updated resolved unit.
     _resetWithIncremental(true);
     analysisContext2.setContents(source, newCode);
     CompilationUnit newUnit = resolveCompilationUnit(source, oldLibrary);
-    List<AnalysisError> newErrors = analysisContext.getErrors(source).errors;
+    List<AnalysisError> newErrors = analysisContext.computeErrors(source);
     // check for expected failure
     if (!expectedSuccess) {
       expect(newUnit.element, isNot(same(oldUnitElement)));
       return;
     }
     // The existing CompilationUnitElement should be updated.
     expect(newUnit.element, same(oldUnitElement));
     // The only expected pending task should return the same resolved
     // "newUnit", so all clients will get it using the usual way.
     AnalysisResult analysisResult = analysisContext.performAnalysisTask();
@@ skipping 298 matching lines @@
   }
 }
 
 
 class _Edit {
   final int offset;
   final int length;
   final String replacement;
   _Edit(this.offset, this.length, this.replacement);
 }