Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 901253002: move relevance computation from client to server (Closed)

Created:
5 years, 10 months ago by danrubel
Modified:
5 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

move relevance computation from client to server BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43519

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -227 lines) Patch
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java View 5 chunks +1 line, -36 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/imported_computer.dart View 3 chunks +21 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/keyword_computer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 10 chunks +46 lines, -16 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 2 3 chunks +18 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 13 chunks +40 lines, -128 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_computer_test.dart View 11 chunks +37 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/local_computer_test.dart View 13 chunks +97 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years, 10 months ago (2015-02-05 19:24:04 UTC) #2
scheglov
lgtm
5 years, 10 months ago (2015-02-05 19:28:54 UTC) #3
danrubel
5 years, 10 months ago (2015-02-05 19:36:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 43519 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698