move relevance computation from client to server

pkg/analysis_server/test/services/completion/imported_computer_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.completion.toplevel;
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/completion/completion_manager.dart';
 import 'package:analysis_server/src/services/completion/dart_completion_cache.dart';
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
@@ skipping 89 matching lines @@
     if (isCached(cache.importedTypeSuggestions, completion) ||
         isCached(cache.importedVoidReturnSuggestions, completion) ||
         isCached(cache.libraryPrefixSuggestions, completion) ||
         isCached(cache.otherImportedSuggestions, completion)) {
       fail('expected $completion NOT to be cached');
     }
   }
 
   @override
   CompletionSuggestion assertSuggestImportedField(String name, String type,
-      [int relevance = COMPLETION_RELEVANCE_DEFAULT]) {
+      {int relevance: DART_RELEVANCE_INHERITED_FIELD}) {
     return assertSuggestField(name, type, relevance: relevance);
   }
 
+  CompletionSuggestion assertSuggestImportedGetter(String name,
+      String returnType, {int relevance: DART_RELEVANCE_INHERITED_ACCESSOR}) {
+    return assertSuggestGetter(name, returnType, relevance: relevance);
+  }
+
+  CompletionSuggestion assertSuggestImportedMethod(String name,
+      String declaringType, String returnType, {int relevance:
+      DART_RELEVANCE_INHERITED_METHOD}) {
+    return assertSuggestMethod(
+        name,
+        declaringType,
+        returnType,
+        relevance: relevance);
+  }
+
+  CompletionSuggestion assertSuggestImportedSetter(String name, {int relevance:
+      DART_RELEVANCE_INHERITED_ACCESSOR}) {
+    return assertSuggestSetter(name, relevance);
+  }
+
   bool isCached(List<CompletionSuggestion> suggestions, String completion) =>
       suggestions.any((CompletionSuggestion s) => s.completion == completion);
 
   @override
   void setUpComputer() {
     computer = new ImportedComputer(shouldWaitForLowPrioritySuggestions: true);
   }
 
   @override
   test_ArgumentList() {
@@ skipping 218 matching lines @@
   void m(x, {int y}) {}
 }
 ''');
     addTestSource('''
 import '/libA.dart';
 class B extends A {
   main() {^}
 }
 ''');
     return computeFull((bool result) {
-      CompletionSuggestion suggestion = assertSuggestMethod('m', 'A', 'void');
+      CompletionSuggestion suggestion =
+          assertSuggestImportedMethod('m', 'A', 'void');
       expect(suggestion.parameterNames, hasLength(2));
       expect(suggestion.parameterNames[0], 'x');
       expect(suggestion.parameterTypes[0], 'dynamic');
       expect(suggestion.parameterNames[1], 'y');
       expect(suggestion.parameterTypes[1], 'int');
       expect(suggestion.requiredParameterCount, 1);
       expect(suggestion.hasNamedParameters, true);
     });
   }
 
   test_method_parameters_mixed_required_and_positional() {
     addSource('/libA.dart', '''
 class A {
   void m(x, [int y]) {}
 }
 ''');
     addTestSource('''
 import '/libA.dart';
 class B extends A {
   main() {^}
 }
 ''');
     return computeFull((bool result) {
-      CompletionSuggestion suggestion = assertSuggestMethod('m', 'A', 'void');
+      CompletionSuggestion suggestion =
+          assertSuggestImportedMethod('m', 'A', 'void');
       expect(suggestion.parameterNames, hasLength(2));
       expect(suggestion.parameterNames[0], 'x');
       expect(suggestion.parameterTypes[0], 'dynamic');
       expect(suggestion.parameterNames[1], 'y');
       expect(suggestion.parameterTypes[1], 'int');
       expect(suggestion.requiredParameterCount, 1);
       expect(suggestion.hasNamedParameters, false);
     });
   }
 
   test_method_parameters_named() {
     addSource('/libA.dart', '''
 class A {
   void m({x, int y}) {}
 }
 ''');
     addTestSource('''
 import '/libA.dart';
 class B extends A {
   main() {^}
 }
 ''');
     return computeFull((bool result) {
-      CompletionSuggestion suggestion = assertSuggestMethod('m', 'A', 'void');
+      CompletionSuggestion suggestion =
+          assertSuggestImportedMethod('m', 'A', 'void');
       expect(suggestion.parameterNames, hasLength(2));
       expect(suggestion.parameterNames[0], 'x');
       expect(suggestion.parameterTypes[0], 'dynamic');
       expect(suggestion.parameterNames[1], 'y');
       expect(suggestion.parameterTypes[1], 'int');
       expect(suggestion.requiredParameterCount, 0);
       expect(suggestion.hasNamedParameters, true);
     });
   }
 
   test_method_parameters_none() {
     addSource('/libA.dart', '''
 class A {
   void m() {}
 }
 ''');
     addTestSource('''
 import '/libA.dart';
 class B extends A {
   main() {^}
 }
 ''');
     computeFast();
     return computeFull((bool result) {
-      CompletionSuggestion suggestion = assertSuggestMethod('m', 'A', 'void');
+      CompletionSuggestion suggestion =
+          assertSuggestImportedMethod('m', 'A', 'void');
       expect(suggestion.parameterNames, isEmpty);
       expect(suggestion.parameterTypes, isEmpty);
       expect(suggestion.requiredParameterCount, 0);
       expect(suggestion.hasNamedParameters, false);
     });
   }
 
   test_method_parameters_positional() {
     addSource('/libA.dart', '''
 class A {
   void m([x, int y]) {}
 }
 ''');
     addTestSource('''
 import '/libA.dart';
 class B extends A {
   main() {^}
 }
 ''');
     return computeFull((bool result) {
-      CompletionSuggestion suggestion = assertSuggestMethod('m', 'A', 'void');
+      CompletionSuggestion suggestion =
+          assertSuggestImportedMethod('m', 'A', 'void');
       expect(suggestion.parameterNames, hasLength(2));
       expect(suggestion.parameterNames[0], 'x');
       expect(suggestion.parameterTypes[0], 'dynamic');
       expect(suggestion.parameterNames[1], 'y');
       expect(suggestion.parameterTypes[1], 'int');
       expect(suggestion.requiredParameterCount, 0);
       expect(suggestion.hasNamedParameters, false);
     });
   }
 
   test_method_parameters_required() {
     addSource('/libA.dart', '''
 class A {
   void m(x, int y) {}
 }
 ''');
     addTestSource('''
 import '/libA.dart';
 class B extends A {
   main() {^}
 }
 ''');
     return computeFull((bool result) {
-      CompletionSuggestion suggestion = assertSuggestMethod('m', 'A', 'void');
+      CompletionSuggestion suggestion =
+          assertSuggestImportedMethod('m', 'A', 'void');
       expect(suggestion.parameterNames, hasLength(2));
       expect(suggestion.parameterNames[0], 'x');
       expect(suggestion.parameterTypes[0], 'dynamic');
       expect(suggestion.parameterNames[1], 'y');
       expect(suggestion.parameterTypes[1], 'int');
       expect(suggestion.requiredParameterCount, 2);
       expect(suggestion.hasNamedParameters, false);
     });
   }
 
@@ skipping 12 matching lines @@
 ''');
     addTestSource('''
 import '/libA.dart';
 class C extends B with M1, M2 {
   void f() {
     ^
   }
 }
 ''');
     return computeFull((bool result) {
-      assertSuggestMethod('m', 'M2', 'void');
+      assertSuggestImportedMethod('m', 'M2', 'void');
     });
   }
 
   /**
    * Ensure that completions in one context don't appear in another
    */
   test_multiple_contexts() {
 
     // Create a 2nd context with source
     var context2 = AnalysisEngine.instance.createAnalysisContext();
@@ skipping 43 matching lines @@
   int x;
 }
 ''');
     addTestSource('''
 import '/libA.dart';
 class B extends A {
   main() {^}
 }
 ''');
     return computeFull((bool result) {
-      CompletionSuggestion suggestion = assertSuggestField('x', 'int');
+      CompletionSuggestion suggestion = assertSuggestImportedField('x', 'int');
       assertHasNoParameterInfo(suggestion);
     });
   }
 
   test_no_parameters_getter() {
     addSource('/libA.dart', '''
 class A {
   int get x => null;
 }
 ''');
     addTestSource('''
 import '/libA.dart';
 class B extends A {
   main() {^}
 }
 ''');
     return computeFull((bool result) {
-      CompletionSuggestion suggestion = assertSuggestGetter('x', 'int');
+      CompletionSuggestion suggestion = assertSuggestImportedGetter('x', 'int');
       assertHasNoParameterInfo(suggestion);
     });
   }
 
   test_no_parameters_setter() {
     addSource('/libA.dart', '''
 class A {
   set x(int value) {};
 }
 ''');
     addTestSource('''
 import '/libA.dart';
 class B extends A {
   main() {^}
 }
 ''');
     return computeFull((bool result) {
-      CompletionSuggestion suggestion = assertSuggestSetter('x');
+      CompletionSuggestion suggestion = assertSuggestImportedSetter('x');
       assertHasNoParameterInfo(suggestion);
     });
   }
 
   @override
   test_partFile_TypeName() {
     return super.test_partFile_TypeName().then((_) {
       expect(request.cache.importKey, 'part of libA;');
     });
   }
 
   @override
   test_partFile_TypeName2() {
     return super.test_partFile_TypeName2().then((_) {
       expect(
           request.cache.importKey,
           'library libA;import "/testB.dart";part "/testA.dart";');
     });
   }
 }