Support default constructors in analyzer2dart.

Support default constructors in analyzer2dart.

BUG=
R=paulberry@google.com, sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43652

[Johnni Winther, 2015-02-09 14:21:28]

johnniwinther@google.com changed reviewers:
+ paulberry@google.com, sigurdm@google.com

[Paul Berry, 2015-02-09 19:07:55]

lgtm

[sigurdm, 2015-02-10 09:37:56]

https://codereview.chromium.org/900403003/diff/1/pkg/analyzer2dart/lib/src/cp...
File pkg/analyzer2dart/lib/src/cps_generator.dart (right):

https://codereview.chromium.org/900403003/diff/1/pkg/analyzer2dart/lib/src/cp...
pkg/analyzer2dart/lib/src/cps_generator.dart:60: // Don't generate CPS for
synthetic (default) constructors.
For the js-case it makes sense to represent these explicitly.
Also we ideally want a check in the dart2dart emitter that excludes any
constructor that is identical to the default one.

https://codereview.chromium.org/900403003/diff/1/pkg/analyzer2dart/lib/src/tr...
File pkg/analyzer2dart/lib/src/tree_shaker.dart (right):

https://codereview.chromium.org/900403003/diff/1/pkg/analyzer2dart/lib/src/tr...
pkg/analyzer2dart/lib/src/tree_shaker.dart:380: if (node.initializers.length !=
1 || node.initializers[0] is! RedirectingConstructorInvocation) {
Long line (was there already)

https://codereview.chromium.org/900403003/diff/1/pkg/analyzer2dart/lib/src/tr...
pkg/analyzer2dart/lib/src/tree_shaker.dart:407:
visitRedirectingConstructorInvocation(RedirectingConstructorInvocation node) {
long line

[Johnni Winther, 2015-02-10 13:49:30]

New patchsets have been uploaded after l-g-t-m from paulberry@google.com

[Johnni Winther, 2015-02-10 13:51:57]

PTAL @ the last patch

https://codereview.chromium.org/900403003/diff/1/pkg/analyzer2dart/lib/src/cp...
File pkg/analyzer2dart/lib/src/cps_generator.dart (right):

https://codereview.chromium.org/900403003/diff/1/pkg/analyzer2dart/lib/src/cp...
pkg/analyzer2dart/lib/src/cps_generator.dart:60: // Don't generate CPS for
synthetic (default) constructors.
On 2015/02/10 09:37:56, sigurdm wrote:
> For the js-case it makes sense to represent these explicitly.
> Also we ideally want a check in the dart2dart emitter that excludes any
> constructor that is identical to the default one.

Reverted.

https://codereview.chromium.org/900403003/diff/1/pkg/analyzer2dart/lib/src/tr...
File pkg/analyzer2dart/lib/src/tree_shaker.dart (right):

https://codereview.chromium.org/900403003/diff/1/pkg/analyzer2dart/lib/src/tr...
pkg/analyzer2dart/lib/src/tree_shaker.dart:380: if (node.initializers.length !=
1 || node.initializers[0] is! RedirectingConstructorInvocation) {
On 2015/02/10 09:37:56, sigurdm wrote:
> Long line (was there already)

The analyzer is dog-fooding the formatter so tolerate this.

https://codereview.chromium.org/900403003/diff/1/pkg/analyzer2dart/lib/src/tr...
pkg/analyzer2dart/lib/src/tree_shaker.dart:407:
visitRedirectingConstructorInvocation(RedirectingConstructorInvocation node) {
On 2015/02/10 09:37:56, sigurdm wrote:
> long line

Ditto.

[sigurdm, 2015-02-10 13:55:31]

LGTM

https://codereview.chromium.org/900403003/diff/1/pkg/analyzer2dart/lib/src/tr...
File pkg/analyzer2dart/lib/src/tree_shaker.dart (right):

https://codereview.chromium.org/900403003/diff/1/pkg/analyzer2dart/lib/src/tr...
pkg/analyzer2dart/lib/src/tree_shaker.dart:380: if (node.initializers.length !=
1 || node.initializers[0] is! RedirectingConstructorInvocation) {
On 2015/02/10 13:51:57, Johnni Winther wrote:
> On 2015/02/10 09:37:56, sigurdm wrote:
> > Long line (was there already)
> 
> The analyzer is dog-fooding the formatter so tolerate this.

Acknowledged.

https://codereview.chromium.org/900403003/diff/1/pkg/analyzer2dart/lib/src/tr...
pkg/analyzer2dart/lib/src/tree_shaker.dart:407:
visitRedirectingConstructorInvocation(RedirectingConstructorInvocation node) {
On 2015/02/10 13:51:57, Johnni Winther wrote:
> On 2015/02/10 09:37:56, sigurdm wrote:
> > long line
> 
> Ditto.

Acknowledged.

[Johnni Winther, 2015-02-10 15:20:40]

Committed patchset #2 (id:20001) manually as 43652 (presubmit successful).