Support default constructors in analyzer2dart.

pkg/analyzer2dart/lib/src/cps_generator.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer2dart.cps_generator;
 
 import 'package:analyzer/analyzer.dart';
 
 import 'package:compiler/src/dart_types.dart' as dart2js;
 import 'package:compiler/src/elements/elements.dart' as dart2js;
@@ skipping 38 matching lines @@
   ir.FieldDefinition visitTopLevelVariableElement(
       analyzer.TopLevelVariableElement element) {
     CpsGeneratingVisitor visitor = new CpsGeneratingVisitor(converter, element);
     VariableDeclaration variableDeclaration = node;
     return visitor.handleFieldDeclaration(element, variableDeclaration);
   }
 
   @override
   ir.ExecutableDefinition visitConstructorElement(
       analyzer.ConstructorElement element) {
+    if (element.isSynthetic) {
+      // Don't generate CPS for synthetic (default) constructors.

[sigurdm, 2015/02/10 09:37:56]

For the js-case it makes sense to represent these explicitly.
Also we ideally want a check in the dart2dart emitter that excludes any
constructor that is identical to the default one.

[Johnni Winther, 2015/02/10 13:51:57]

Reverted.

+      return null;
+    }
     CpsGeneratingVisitor visitor = new CpsGeneratingVisitor(converter, element);
     if (!element.isFactory) {
       ConstructorDeclaration constructorDeclaration = node;
-      FunctionBody body;
-      if (constructorDeclaration != null) {
-        body = constructorDeclaration.body;
-      } else {
-        assert(element.isSynthetic);
-      }
-      return visitor.handleConstructorDeclaration(element, body);
+      return visitor.handleConstructorDeclaration(element,
+          constructorDeclaration.body);
     }
     // TODO(johnniwinther): Support factory constructors.
     return null;
   }
 }
 
 /// Visitor that converts analyzer AST nodes into CPS ir nodes.
 class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
     with IrBuilderMixin<AstNode> {
   /// Promote the type of [irBuilder] to [DartIrBuilder].
@@ skipping 490 matching lines @@
     return irBuilder.buildTypeOperator(
         visit(node.expression),
         converter.convertType(node.type.type),
         isTypeTest: false);
   }
 }
 
 class NullCapturedVariableInfo extends DartCapturedVariableInfo {
   Iterable get capturedVariables => const [];
 }