Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 899243002: Make standalone tests not dependent on current working directory. (Closed)

Created:
5 years, 10 months ago by ricow1
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make standalone tests not dependent on current working directory. This also simplifies DartOptions - could we simply remove it, the only usage is the arguments test which could simply call the vm on another file, and validate the output? R=iposva@google.com, sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43511

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove stray blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -26 lines) Patch
M tests/standalone/full_coverage_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/arguments_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_input_stream_test.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M tests/standalone/io/file_invalid_arguments_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/standalone/io/file_test.dart View 4 chunks +9 lines, -8 lines 0 comments Download
M tests/standalone/io/platform_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/io/read_into_const_list_test.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 1 chunk +2 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ricow1
5 years, 10 months ago (2015-02-05 13:18:31 UTC) #1
Ivan Posva
LGTM -Ivan https://codereview.chromium.org/899243002/diff/1/tests/standalone/full_coverage_test.dart File tests/standalone/full_coverage_test.dart (right): https://codereview.chromium.org/899243002/diff/1/tests/standalone/full_coverage_test.dart#newcode17 tests/standalone/full_coverage_test.dart:17: Platform.script.resolve('../../tools/full-coverage.dart').toFilePath(); Do / work on windows? https://codereview.chromium.org/899243002/diff/1/tools/testing/dart/test_suite.dart ...
5 years, 10 months ago (2015-02-05 14:46:20 UTC) #2
ricow1
https://codereview.chromium.org/899243002/diff/1/tests/standalone/full_coverage_test.dart File tests/standalone/full_coverage_test.dart (right): https://codereview.chromium.org/899243002/diff/1/tests/standalone/full_coverage_test.dart#newcode17 tests/standalone/full_coverage_test.dart:17: Platform.script.resolve('../../tools/full-coverage.dart').toFilePath(); On 2015/02/05 14:46:20, Ivan Posva wrote: > Do ...
5 years, 10 months ago (2015-02-05 15:08:34 UTC) #4
Søren Gjesse
lgtm
5 years, 10 months ago (2015-02-05 15:29:59 UTC) #5
ricow1
5 years, 10 months ago (2015-02-05 16:29:53 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43511 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698