Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 899243002: Make standalone tests not dependent on current working directory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove stray blank line Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/read_into_const_list_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index b29c3f0130e55a515e1cd325aae668d5470c4bdf..b7aaedb621afa36b6ded49dceb6c3d7bfeec747d 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1551,17 +1551,8 @@ class StandardTestSuite extends TestSuite {
List<String> dartOptions = optionsFromFile["dartOptions"];
assert(!isMultitest || dartOptions == null);
- if (dartOptions == null) {
- args.add(filePath.toNativePath());
- } else {
- var executable_name = dartOptions[0];
- // TODO(ager): Get rid of this hack when the runtime checkout goes away.
- var file = new File(executable_name);
- if (!file.existsSync()) {
- executable_name = '../$executable_name';
- assert(new File(executable_name).existsSync());
- dartOptions[0] = executable_name;
- }
+ args.add(filePath.toNativePath());
+ if (dartOptions != null) {
args.addAll(dartOptions);
}
« no previous file with comments | « tests/standalone/io/read_into_const_list_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698