Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 898993002: Clamp scrollX, scrollY, pageXOffset, and pageYOffset from double to int (Closed)

Created:
5 years, 10 months ago by terry
Modified:
5 years, 10 months ago
Reviewers:
vsm, siva
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clamp scrollX, scrollY, pageXOffset, and pageYOffset from double to int TBR=vsm@google.com,asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=43477

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -14 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 6 chunks +22 lines, -6 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +19 lines, -4 lines 2 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 3 chunks +34 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
terry
5 years, 10 months ago (2015-02-04 16:13:56 UTC) #1
terry
5 years, 10 months ago (2015-02-04 16:15:11 UTC) #3
terry
Committed patchset #1 (id:1) manually as 43477 (presubmit successful).
5 years, 10 months ago (2015-02-04 16:59:19 UTC) #4
siva
lgtm
5 years, 10 months ago (2015-02-04 17:08:51 UTC) #5
vsm
https://codereview.chromium.org/898993002/diff/1/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (right): https://codereview.chromium.org/898993002/diff/1/sdk/lib/html/dartium/html_dartium.dart#newcode33210 sdk/lib/html/dartium/html_dartium.dart:33210: + int get _pageXOffset => _blink.BlinkWindow.instance.pageXOffset_Getter_(this); Should this be ...
5 years, 10 months ago (2015-02-04 17:10:44 UTC) #6
terry
5 years, 10 months ago (2015-02-04 17:19:25 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/898993002/diff/1/sdk/lib/html/dartium/html_da...
File sdk/lib/html/dartium/html_dartium.dart (right):

https://codereview.chromium.org/898993002/diff/1/sdk/lib/html/dartium/html_da...
sdk/lib/html/dartium/html_dartium.dart:33210: +  int get _pageXOffset =>
_blink.BlinkWindow.instance.pageXOffset_Getter_(this);
On 2015/02/04 17:10:43, vsm wrote:
> Should this be typed int or double?  If int, why do you round the result
below?

It should be double (I'll make the 39 roll IDL change for these 4 properties).

Powered by Google App Engine
This is Rietveld 408576698