Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 897643002: dart2js: move generation of noSuchMethodStubs into ClassStubGenerator. (Closed)

Created:
5 years, 10 months ago by zarah
Modified:
5 years, 10 months ago
Reviewers:
floitsch, herhut
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: move generation of noSuchMethod stubs into ClassStubGenerator. Depends on https://codereview.chromium.org/895893002/ . R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43391

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merged changes from depending cl. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -73 lines) Patch
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 1 1 chunk +73 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart View 1 2 chunks +5 lines, -73 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zarah
5 years, 10 months ago (2015-02-03 09:42:39 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/897643002/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right): https://codereview.chromium.org/897643002/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart#newcode29 pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:29: generator.computeSelectorsForNsmHandlers(addedJsNames); In the next CL return the map ...
5 years, 10 months ago (2015-02-03 10:48:51 UTC) #3
zarah
https://codereview.chromium.org/897643002/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right): https://codereview.chromium.org/897643002/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart#newcode29 pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:29: generator.computeSelectorsForNsmHandlers(addedJsNames); On 2015/02/03 10:48:51, floitsch wrote: > In the ...
5 years, 10 months ago (2015-02-03 11:55:18 UTC) #5
zarah
5 years, 10 months ago (2015-02-03 12:17:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as 43391 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698