Add support for user info on ws: and wss: URLs

Add support for user info on ws: and wss: URLs

BUG=http://dartbug.com/22152
R=kustermann@google.com, lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43586

[kustermann, 2015-02-06 13:13:46]

lgtm

https://codereview.chromium.org/897323002/diff/1/sdk/lib/io/websocket_impl.dart
File sdk/lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/897323002/diff/1/sdk/lib/io/websocket_impl.da...
sdk/lib/io/websocket_impl.dart:815: }
Maybe move this before the `if (headers != null) {...}`, so users the `headers`
setting can potentially override the userinfo one?

https://codereview.chromium.org/897323002/diff/1/tests/standalone/io/web_sock...
File tests/standalone/io/web_socket_test.dart (right):

https://codereview.chromium.org/897323002/diff/1/tests/standalone/io/web_sock...
tests/standalone/io/web_socket_test.dart:482: webSocket.add("Hello");
Why do you close inside listen and add one line after?

Maybe

webSocket.drain();
webSocket
  ..add('Hello')
  ..close();

https://codereview.chromium.org/897323002/diff/1/tests/standalone/io/web_sock...
tests/standalone/io/web_socket_test.dart:491: websocket.close();
-> `return websocket.close()`

https://codereview.chromium.org/897323002/diff/1/tests/standalone/io/web_sock...
tests/standalone/io/web_socket_test.dart:494: server.close();
-> `return server.close();`

before asyncEnd()

[Søren Gjesse, 2015-02-09 08:59:40]

New patchsets have been uploaded after l-g-t-m from kustermann@google.com

[Søren Gjesse, 2015-02-09 09:18:02]

Committed patchset #2 (id:20001) manually as 43586 (presubmit successful).

[Søren Gjesse, 2015-02-09 10:39:00]

https://codereview.chromium.org/897323002/diff/1/sdk/lib/io/websocket_impl.dart
File sdk/lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/897323002/diff/1/sdk/lib/io/websocket_impl.da...
sdk/lib/io/websocket_impl.dart:815: }
On 2015/02/06 13:13:46, kustermann wrote:
> Maybe move this before the `if (headers != null) {...}`, so users the
`headers`
> setting can potentially override the userinfo one?

Good point, done.

https://codereview.chromium.org/897323002/diff/1/tests/standalone/io/web_sock...
File tests/standalone/io/web_socket_test.dart (right):

https://codereview.chromium.org/897323002/diff/1/tests/standalone/io/web_sock...
tests/standalone/io/web_socket_test.dart:482: webSocket.add("Hello");
On 2015/02/06 13:13:46, kustermann wrote:
> Why do you close inside listen and add one line after?
> 
> Maybe
> 
> webSocket.drain();
> webSocket
>   ..add('Hello')
>   ..close();

This test just sends "Hello" back, but no data is send from the other side. So
the onData in listen is never called, and the close is dead code. Changed onData
to throw, and added asyncEnd to onDone (after adding one more asyncStart().

https://codereview.chromium.org/897323002/diff/1/tests/standalone/io/web_sock...
tests/standalone/io/web_socket_test.dart:491: websocket.close();
On 2015/02/06 13:13:46, kustermann wrote:
> -> `return websocket.close()` 

Why? The future is the asFuture on the stream subscription which is unrelated to
the return value from the onData closure.

https://codereview.chromium.org/897323002/diff/1/tests/standalone/io/web_sock...
tests/standalone/io/web_socket_test.dart:494: server.close();
On 2015/02/06 13:13:46, kustermann wrote:
> -> `return server.close();`
> 
> before asyncEnd()

Done. Moved asyncEnd to whenComplete.