Add support for user info on ws: and wss: URLs

tests/standalone/io/web_socket_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // VMOptions=
 // VMOptions=--short_socket_read
 // VMOptions=--short_socket_write
 // VMOptions=--short_socket_read --short_socket_write
 
 import "dart:async";
+import "dart:convert";
 import "dart:io";
 import "dart:typed_data";
 
 import "package:async_helper/async_helper.dart";
 import "package:crypto/crypto.dart";
 import "package:expect/expect.dart";
 import "package:path/path.dart";
 
 const WEB_SOCKET_GUID = "258EAFA5-E914-47DA-95CA-C5AB0DC85B11";
 
@@ skipping 424 matching lines @@
         Expect.equals('my-value-1, my-value-2', header[0]);
         WebSocketTransformer.upgrade(request).then((webSocket) {
           webSocket.listen((_) { webSocket.close(); });
           webSocket.add("Hello");
         });
       });
 
       var url = '${secure ? "wss" : "ws"}://$HOST_NAME:${server.port}/';
       var headers = {'My-Header': 'my-value',
                      'My-Header-Multiple': ['my-value-1', 'my-value-2']};
-      print(headers);
-      print(headers['My-Header-Multiple'] is Iterable);
-      print(headers['My-Header-Multiple'].length);
       WebSocket.connect(url, headers: headers).then((websocket) {
         return websocket.listen((message) {
           Expect.equals("Hello", message);
           websocket.close();
         }).asFuture();
       }).then((_) {
         server.close();
         asyncEnd();
       });
     });
   }
 
 
+  void testBasicAuthentication() {
+    var userInfo = 'user:password';
+  
+    asyncStart();
+    createServer().then((server) {
+      server.listen((request) {
+        Expect.isTrue(WebSocketTransformer.isUpgradeRequest(request));
+        String auth =
+              CryptoUtils.bytesToBase64(UTF8.encode(userInfo));
+        Expect.equals('Basic $auth', request.headers['Authorization'][0]);
+        Expect.equals(1, request.headers['Authorization'].length);
+        WebSocketTransformer.upgrade(request).then((webSocket) {
+          webSocket.listen((_) { webSocket.close(); });
+          webSocket.add("Hello");

[kustermann, 2015/02/06 13:13:46]

Why do you close inside listen and add one line after?

Maybe

webSocket.drain();
webSocket
  ..add('Hello')
  ..close();

[Søren Gjesse, 2015/02/09 10:38:59]

This test just sends "Hello" back, but no data is send from the other side. So
the onData in listen is never called, and the close is dead code. Changed onData
to throw, and added asyncEnd to onDone (after adding one more asyncStart().

+        });
+      });
+
+      var url =
+          '${secure ? "wss" : "ws"}://$userInfo@$HOST_NAME:${server.port}/';
+      WebSocket.connect(url).then((websocket) {
+        return websocket.listen((message) {
+          Expect.equals("Hello", message);
+          websocket.close();

[kustermann, 2015/02/06 13:13:46]

-> `return websocket.close()` 

[Søren Gjesse, 2015/02/09 10:38:59]

Why? The future is the asFuture on the stream subscription which is unrelated to
the return value from the onData closure.

+        }).asFuture();
+      }).then((_) {
+        server.close();

[kustermann, 2015/02/06 13:13:46]

-> `return server.close();`

before asyncEnd()

[Søren Gjesse, 2015/02/09 10:38:59]

Done. Moved asyncEnd to whenComplete.

+        asyncEnd();
+      });
+    });
+  }
+
   void runTests() {
     testRequestResponseClientCloses(2, null, null, 1);
     testRequestResponseClientCloses(2, 3001, null, 2);
     testRequestResponseClientCloses(2, 3002, "Got tired", 3);
     testRequestResponseServerCloses(2, null, null);
     testRequestResponseServerCloses(2, 3001, null);
     testRequestResponseServerCloses(2, 3002, "Got tired");
     testMessageLength(125);
     testMessageLength(126);
     testMessageLength(127);
     testMessageLength(65535);
     testMessageLength(65536);
     testDoubleCloseClient();
     testDoubleCloseServer();
     testImmediateCloseServer();
     testImmediateCloseClient();
     testNoUpgrade();
     testUsePOST();
     testConnections(10, 3002, "Got tired");
     testIndividualUpgrade(5);
     testFromUpgradedSocket();
     testAdditionalHeaders();
+    testBasicAuthentication();
   }
 }
 
 
 void initializeSSL() {
   var testPkcertDatabase = Platform.script.resolve('pkcert').toFilePath();
   SecureSocket.initialize(database: testPkcertDatabase,
                           password: "dartdart");
 }
 
 
 main() {
   new SecurityConfiguration(secure: false).runTests();
   initializeSSL();
   new SecurityConfiguration(secure: true).runTests();
 }