Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 897243003: dart2js: remove (broken) support for nsm on native classes. (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, sra1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: remove (broken) support for nsm on native classes. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=43759

Patch Set 1 #

Patch Set 2 : Fix test and provide nice error message. #

Patch Set 3 : Fix bad removal and update status file. #

Patch Set 4 : Remove whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -40 lines) Patch
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 2 chunks +2 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 2 chunks +20 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception4_frog_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
floitsch
@Johnni: where would you check for this? Basically we want to give an error message: ...
5 years, 10 months ago (2015-02-09 15:02:40 UTC) #2
floitsch
Without the early error not yet ready for review. I will reping once I have ...
5 years, 10 months ago (2015-02-09 15:03:26 UTC) #3
Johnni Winther
On 2015/02/09 15:03:26, floitsch wrote: > Without the early error not yet ready for review. ...
5 years, 10 months ago (2015-02-10 14:19:47 UTC) #4
floitsch
PTAL. I wouldn't be surprised if my helper already existed, and if you prefered to ...
5 years, 10 months ago (2015-02-11 19:56:20 UTC) #5
Johnni Winther
lgtm
5 years, 10 months ago (2015-02-13 10:17:57 UTC) #6
floitsch
5 years, 10 months ago (2015-02-13 14:20:18 UTC) #7
floitsch
5 years, 10 months ago (2015-02-13 14:20:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 43759 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698