Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

Issue 897243003: dart2js: remove (broken) support for nsm on native classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove whitespace Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart
index 93f866bdc9ebea2f244e8bfbecd2c8b7d36dbb5a..a3e5a38ea5865eaf638f34018a5eb882b48e5c49 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart
@@ -280,11 +280,6 @@ class NsmEmitter extends CodeEmitterHelper {
' objectClassObject = objectClassObject[1];'));
}
- // TODO(9631): This is no longer valid for native methods.
- String whatToPatch = emitter.nativeEmitter.handleNoSuchMethod ?
- "Object.prototype" :
- "objectClassObject";
-
List<jsAst.Expression> sliceOffsetArguments =
firstNormalSelector == 0
? []
@@ -309,8 +304,8 @@ class NsmEmitter extends CodeEmitterHelper {
// createInvocationMirror(String name, internalName, type,
// arguments, argumentNames)
//
- $whatToPatch[short] = (function(name, short,
- type, #sliceOffsetParams) {
+ objectClassObject[short] = (function(name, short,
+ type, #sliceOffsetParams) {
return function() {
return this.#noSuchMethodName(this,
#createInvocationMirror(name, short, type,
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart ('k') | pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698