Finish moving service protocol to json rpc.

Finish moving service protocol to json rpc.

Service

- Remove support for old-style service requests.

- Drop 'arguments' from JsonStream and ServiceRequestHandler.

- Json-rpc inspired renaming: command->method, options->params all over.

- Implement getFlagList, setFlag, getObjectByAddress.

- Add helpers PrintMissingParamError and PrintInvalidParamError
  to make our error messages more regular.

- Update tests.

- Service_SetSource removed for now.  John will resurrect.

Observatory

- Drop all Deprecated 'get' functions.  We now use json rpc for everything.

- Drop 'link' and 'relativeLink' from ServiceObject -- they were
  ui-specific and they are no longer meaningful anyways.  Use 'id' instead.

- New pages: VMPage, FlagsPage, InspectPage, ErrorPage.  All urls
  used by Observatory are now 'new school' and have a proper
  prefix.  ErrorPage is the new catch-all.

- Pages now use a Uri instead of a url String.  This lets them
  grab query parameters more easily.

- SimplePage replaces IsolateSuffixPage.

- We now use gotoLink() or makeLink() to make our navigation
  links.  gotoLink gets some optional parameters to make it
  easier to construct links to ServiceObjects.

- Rework mouse clicks on the heap map to use getObjectByAddress.

- Remove the breakpoint_list.  It wasn't working.  I'll add it back later.

- Silence logging of getIsolateMetric/getVMMetric.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43514

[turnidge, 2015-02-05 02:30:12]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[turnidge, 2015-02-05 02:30:13]

heap_map breaks in javascript version.  Still tracking that down.  Otherwise,
ready for review.

[Cutch, 2015-02-05 14:54:48]

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
File runtime/observatory/lib/src/app/page.dart (right):

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
runtime/observatory/lib/src/app/page.dart:86: // Nothing requested.
Should we display something in this case?

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
File runtime/observatory/lib/src/elements/cpu_profile.html (right):

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/cpu_profile.html:14: <nav-menu link="{{
'/profiler/' + isolate.id }}" anchor="cpu profile" last="{{ true }}"></nav-menu>
Why not makeLink('/profiler', isolate) here and elsewhere ?

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
File runtime/observatory/lib/src/elements/debugger.html (right):

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/debugger.html:60: <nav-menu link="{{
'/debugger/' + isolate.id) }}" anchor="debugger" last="{{ true }}"></nav-menu>
here too.

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
File runtime/observatory/lib/src/elements/flag_list.html (right):

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/flag_list.html:10: <nav-menu link="{{
'flags' }}" anchor="flags" last="{{ true }}"></nav-menu>
{{ makeLink('/flags') }}

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
runtime/observatory/lib/src/service/object.dart:1239: print('address is
$address');
remove

https://codereview.chromium.org/897193002/diff/20001/runtime/vm/service/vmser...
File runtime/vm/service/vmservice.dart (right):

https://codereview.chromium.org/897193002/diff/20001/runtime/vm/service/vmser...
runtime/vm/service/vmservice.dart:145: if (message.params['isolate'] != null) {
in the Uri we use 'isolateId' but here we use the parameter name 'isolate'. I
think we should use 'isolateId' as the RPC parameter name. This makes us
consistent with 'objectId' too.

[turnidge, 2015-02-05 17:11:36]

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
File runtime/observatory/lib/src/app/page.dart (right):

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
runtime/observatory/lib/src/app/page.dart:86: // Nothing requested.
On 2015/02/05 14:54:48, Cutch wrote:
> Should we display something in this case?

Removed.

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
File runtime/observatory/lib/src/elements/cpu_profile.html (right):

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/cpu_profile.html:14: <nav-menu link="{{
'/profiler/' + isolate.id }}" anchor="cpu profile" last="{{ true }}"></nav-menu>
On 2015/02/05 14:54:48, Cutch wrote:
> Why not makeLink('/profiler', isolate) here and elsewhere ?

Done.

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
File runtime/observatory/lib/src/elements/debugger.html (right):

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/debugger.html:60: <nav-menu link="{{
'/debugger/' + isolate.id) }}" anchor="debugger" last="{{ true }}"></nav-menu>
On 2015/02/05 14:54:48, Cutch wrote:
> here too.

Done.

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
File runtime/observatory/lib/src/elements/flag_list.html (right):

https://codereview.chromium.org/897193002/diff/20001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/flag_list.html:10: <nav-menu link="{{
'flags' }}" anchor="flags" last="{{ true }}"></nav-menu>
On 2015/02/05 14:54:48, Cutch wrote:
> {{ makeLink('/flags') }}

Done.

[Cutch, 2015-02-05 17:12:51]

lgtm

[turnidge, 2015-02-05 17:46:32]

Committed patchset #4 (id:60001) manually as 43514 (presubmit successful).