Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: runtime/observatory/lib/src/elements/observatory_element.dart

Issue 897193002: Finish moving service protocol to json rpc. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/observatory_element.dart
diff --git a/runtime/observatory/lib/src/elements/observatory_element.dart b/runtime/observatory/lib/src/elements/observatory_element.dart
index b31ac9448b6d7b8e7f6afd8efd9821b4d5cc8755..9e9a363d7f0f0e4ac61ab68d212c94b27a37144a 100644
--- a/runtime/observatory/lib/src/elements/observatory_element.dart
+++ b/runtime/observatory/lib/src/elements/observatory_element.dart
@@ -7,6 +7,7 @@ library observatory_element;
import 'dart:async';
import 'dart:html';
import 'package:observatory/app.dart';
+import 'package:observatory/service.dart';
import 'package:polymer/polymer.dart';
/// Base class for all Observatory custom elements.
@@ -91,9 +92,21 @@ class ObservatoryElement extends PolymerElement {
event.stopPropagation();
}
+ String makeLink(String url, [ServiceObject obj]) {
+ if (obj != null) {
+ if (obj is Isolate) {
+ url = '${url}?isolateId=${Uri.encodeComponent(obj.id)}';
+ } else {
+ url = ('${url}?isolateId=${Uri.encodeComponent(obj.isolate.id)}'
+ '&objectId=${Uri.encodeComponent(obj.id)}');
+ }
+ }
+ return url;
+ }
+
/// Create a link that can be consumed by [goto].
- String gotoLink(String url) {
- return app.locationManager.makeLink(url);
+ String gotoLink(String url, [ServiceObject obj]) {
+ return app.locationManager.makeLink(makeLink(url, obj));
}
String formatTimePrecise(double time) => Utils.formatTimePrecise(time);
« no previous file with comments | « runtime/observatory/lib/src/elements/nav_bar.html ('k') | runtime/observatory/lib/src/elements/script_view.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698