Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 896763003: dart2js: emit noSuchMethod stubs in the new emitter. (Closed)

Created:
5 years, 10 months ago by zarah
Modified:
5 years, 10 months ago
Reviewers:
floitsch, herhut
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: emit noSuchMethod stubs in the new emitter. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43399

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't emit nsm stubs twice. #

Patch Set 3 : Forgot to save. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -20 lines) Patch
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 1 2 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/model.dart View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart View 1 1 chunk +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 1 5 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
zarah
5 years, 10 months ago (2015-02-03 12:30:51 UTC) #1
zarah
5 years, 10 months ago (2015-02-03 12:34:43 UTC) #3
floitsch
LGTM. https://codereview.chromium.org/896763003/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right): https://codereview.chromium.org/896763003/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart#newcode54 pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:54: addProperty(jsName, method.code); addProperty(method.name, method.code) ? assert that they ...
5 years, 10 months ago (2015-02-03 13:07:08 UTC) #4
zarah
PTAL https://codereview.chromium.org/896763003/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right): https://codereview.chromium.org/896763003/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart#newcode54 pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:54: addProperty(jsName, method.code); On 2015/02/03 13:07:08, floitsch wrote: > ...
5 years, 10 months ago (2015-02-03 14:07:10 UTC) #6
zarah
Committed patchset #3 (id:60001) manually as 43399 (presubmit successful).
5 years, 10 months ago (2015-02-03 14:25:51 UTC) #7
floitsch
5 years, 10 months ago (2015-02-03 19:28:54 UTC) #8
Message was sent while issue was closed.
Still LGTM.

Powered by Google App Engine
This is Rietveld 408576698