Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 896723009: Annotate dart:html constructor expressions with precise non-nullable types. (Closed)

Created:
5 years, 10 months ago by sra1
Modified:
5 years, 10 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Annotate dart:html constructor expressions with precise non-nullable types. This addresses issue http://dartbug.com/22264 R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=43578

Patch Set 1 #

Patch Set 2 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -144 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 56 chunks +61 lines, -61 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 63 chunks +63 lines, -63 lines 0 comments Download
M tests/html/element_types_test.dart View 1 2 chunks +118 lines, -9 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 2 chunks +17 lines, -11 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +21 lines, -0 lines 6 comments Download

Messages

Total messages: 4 (1 generated)
Alan Knight
lgtm https://codereview.chromium.org/896723009/diff/20001/tools/dom/scripts/systemhtml.py File tools/dom/scripts/systemhtml.py (right): https://codereview.chromium.org/896723009/diff/20001/tools/dom/scripts/systemhtml.py#newcode727 tools/dom/scripts/systemhtml.py:727: if factory_name == 'document' and factory_constructor_name == 'createElement': ...
5 years, 10 months ago (2015-02-06 18:41:03 UTC) #2
sra1
https://chromiumcodereview.appspot.com/896723009/diff/20001/tools/dom/scripts/systemhtml.py File tools/dom/scripts/systemhtml.py (right): https://chromiumcodereview.appspot.com/896723009/diff/20001/tools/dom/scripts/systemhtml.py#newcode727 tools/dom/scripts/systemhtml.py:727: if factory_name == 'document' and factory_constructor_name == 'createElement': On ...
5 years, 10 months ago (2015-02-06 22:45:44 UTC) #3
sra1
5 years, 10 months ago (2015-02-06 23:24:28 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43578 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698