Annotate dart:html constructor expressions with precise non-nullable types.

tools/dom/scripts/systemhtml.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the system to generate
 Dart:html APIs from the IDL database."""
 
 import emitter
 import logging
@@ skipping 704 matching lines @@
         self._renamer.RenameInterface(self._interface)))
     return js_support_checks.get(self._interface.doc_js_name)
 
   def GenerateCustomFactory(self, constructor_info):
     # Custom factory will be taken from the template.
     return self._interface.doc_js_name in _js_custom_constructors
 
   def IsConstructorArgumentOptional(self, argument):
     return argument.optional
 
+  def XXFactoryConstructorExpression(self, constructor_info,
+      factory_name, factory_constructor_name, factory_parameters):
+    if factory_name == 'document' and factory_constructor_name == 'createElement':

[Alan Knight, 2015/02/06 18:41:03]

80 columns

[sra1, 2015/02/06 22:45:44]

Done.

+      return emitter.Format(
+          '''JS('$TYPE', '$FACTORY.$CTOR_FACTORY_NAME($FACTORY_PARAMS))''',
+          TYPE=self._DartType(constructor_info.type_name),
+          FACTORY=factory_name,
+          CTOR_FACTORY_NAME=factory_constructor_name,
+          FACTORY_PARAMS=factory_parameters);
+    return super(Dart2JSBackend, self).FactoryConstructorExpression(
+        constructor_info, factory_name, factory_constructor_name, factory_parameters)

[Alan Knight, 2015/02/06 18:41:03]

and here

[sra1, 2015/02/06 22:45:44]

Done.

+
+  def FactoryConstructorExpression(self, constructor_info,
+      factory_name, factory_constructor_name, factory_parameters):
+    expression = super(Dart2JSBackend, self).FactoryConstructorExpression(
+        constructor_info, factory_name, factory_constructor_name, factory_parameters)

[Alan Knight, 2015/02/06 18:41:02]

also 80 cols

[sra1, 2015/02/06 22:45:44]

Done.

+    return emitter.Format(
+        "JS('$TYPE', '#', $VALUE)",
+        TYPE=self._DartType(constructor_info.type_name),
+        VALUE=expression)
+
   def EmitStaticFactoryOverload(self, constructor_info, name, arguments):
     index = len(arguments)
     arguments = constructor_info.ParametersAsArgumentList(index)
     if arguments:
       arguments = ', ' + arguments
     self._members_emitter.Emit(
         "  static $INTERFACE_NAME $NAME($PARAMETERS) => "
           "JS('$INTERFACE_NAME', 'new $CTOR_NAME($PLACEHOLDERS)'$ARGUMENTS);\n",
         INTERFACE_NAME=self._interface_type_info.interface_name(),
         NAME=name,
@@ skipping 534 matching lines @@
 
   def AddFile(self, basename, library_name, path):
     self._libraries[library_name].AddFile(path)
 
   def AddTypeEntry(self, library_name, idl_name, dart_name):
     self._libraries[library_name].AddTypeEntry(idl_name, dart_name)
 
   def Emit(self, emitter, auxiliary_dir):
     for lib in self._libraries.values():
       lib.Emit(emitter, auxiliary_dir)