Issue 896343003: Cherry-pick potential divide-by-zero fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 896343003: Cherry-pick potential divide-by-zero fix (Closed)

Created:
5 years, 10 months ago by Johann

Modified:
5 years, 10 months ago

Reviewers:
Yaowu, Tom Finegan

CC:
wwcv, jzern, fgalligan1

Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@m41-2272

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Cherry-pick potential divide-by-zero fix This is a bit more than a potential fix now. It's been in canary for a week and was recently promoted to dev. No further instances of the issue have shown up in the crash tracker. https://codereview.chromium.org/877783004 Replace divide with look-up This commit replaces an integer divide with a table-lookup. It is to improve decoding speed, and at the same time, to reduce possible complications with a bug in AMD Family 12h processors: "665 Integer Divide Instruction May Cause Unpredictable Behavior" R=yaowu@chromium.org BUG=396572 Committed: 193e7c1b434f03ccd82b1cd9035bc0bc4c28bb7b

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -76 lines)			Patch
M	source/libvpx/vp9/common/vp9_entropymode.c	View	3 chunks	+26 lines, -37 lines	0 comments	Download
M	source/libvpx/vp9/common/vp9_entropymv.c	View	3 chunks	+13 lines, -24 lines	0 comments	Download
M	source/libvpx/vp9/common/vp9_prob.h	View	2 chunks	+23 lines, -2 lines	0 comments	Download
M	source/libvpx/vp9/common/vp9_prob.c	View	1 chunk	+5 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johann

5 years, 10 months ago (2015-02-05 20:02:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
193e7c1b434f03ccd82b1cd9035bc0bc4c28bb7b (presubmit successful).

Expand Messages | Collapse Messages