Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 896213002: Revert "Introduce optional 'bool shared' parameter to ServerSocket.bind() ..." (Closed)

Created:
5 years, 10 months ago by kustermann
Modified:
5 years, 10 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Introduce optional 'bool shared' parameter to ServerSocket.bind() ..." Committed: https://code.google.com/p/dart/source/detail?r=43476

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+675 lines, -1384 lines) Patch
M dart/runtime/bin/eventhandler.h View 3 chunks +0 lines, -438 lines 0 comments Download
M dart/runtime/bin/eventhandler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M dart/runtime/bin/eventhandler_android.h View 3 chunks +45 lines, -21 lines 0 comments Download
M dart/runtime/bin/eventhandler_android.cc View 12 chunks +67 lines, -106 lines 0 comments Download
M dart/runtime/bin/eventhandler_linux.h View 3 chunks +230 lines, -18 lines 0 comments Download
M dart/runtime/bin/eventhandler_linux.cc View 8 chunks +52 lines, -81 lines 0 comments Download
M dart/runtime/bin/eventhandler_macos.h View 3 chunks +45 lines, -33 lines 0 comments Download
M dart/runtime/bin/eventhandler_macos.cc View 8 chunks +61 lines, -97 lines 0 comments Download
M dart/runtime/bin/eventhandler_win.h View 14 chunks +49 lines, -32 lines 0 comments Download
M dart/runtime/bin/eventhandler_win.cc View 21 chunks +76 lines, -92 lines 0 comments Download
M dart/runtime/bin/io_natives.cc View 2 chunks +1 line, -2 lines 0 comments Download
M dart/runtime/bin/socket.h View 3 chunks +0 lines, -87 lines 0 comments Download
M dart/runtime/bin/socket.cc View 4 chunks +14 lines, -154 lines 0 comments Download
M dart/runtime/bin/socket_patch.dart View 12 chunks +24 lines, -41 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/js_lib/io_patch.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M dart/sdk/lib/io/secure_server_socket.dart View 3 chunks +4 lines, -8 lines 0 comments Download
M dart/sdk/lib/io/socket.dart View 2 chunks +2 lines, -4 lines 0 comments Download
D dart/tests/standalone/io/socket_bind_test.dart View 1 chunk +0 lines, -165 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kustermann
5 years, 10 months ago (2015-02-04 15:28:50 UTC) #1
kustermann
TBR
5 years, 10 months ago (2015-02-04 15:59:55 UTC) #2
kustermann
Committed patchset #1 (id:1) manually as 43476.
5 years, 10 months ago (2015-02-04 16:00:42 UTC) #3
Søren Gjesse
5 years, 10 months ago (2015-02-04 16:33:00 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698