Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1935)

Unified Diff: dart/runtime/bin/socket.h

Issue 896213002: Revert "Introduce optional 'bool shared' parameter to ServerSocket.bind() ..." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/runtime/bin/io_natives.cc ('k') | dart/runtime/bin/socket.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/runtime/bin/socket.h
diff --git a/dart/runtime/bin/socket.h b/dart/runtime/bin/socket.h
index 9a5d90e231d9baf33e9d311fbe85eef742da85de..ff5444daa585f4546d8c2421e657565bd99e393b 100644
--- a/dart/runtime/bin/socket.h
+++ b/dart/runtime/bin/socket.h
@@ -5,8 +5,6 @@
#ifndef BIN_SOCKET_H_
#define BIN_SOCKET_H_
-#include <map>
-
#include "platform/globals.h"
#include "bin/builtin.h"
@@ -78,21 +76,6 @@ class SocketAddress {
sizeof(struct in6_addr) : sizeof(struct in_addr);
}
- static bool AreAddressesEqual(const RawAddr& a, const RawAddr& b) {
- if (a.ss.ss_family == AF_INET) {
- if (b.ss.ss_family != AF_INET) return false;
- return memcmp(&a.in.sin_addr, &b.in.sin_addr, sizeof(a.in.sin_addr)) == 0;
- } else if (a.ss.ss_family == AF_INET6) {
- if (b.ss.ss_family != AF_INET6) return false;
- return memcmp(&a.in6.sin6_addr,
- &b.in6.sin6_addr,
- sizeof(a.in6.sin6_addr)) == 0;
- } else {
- UNREACHABLE();
- return false;
- }
- }
-
static void GetSockAddr(Dart_Handle obj, RawAddr* addr) {
Dart_TypedData_Type data_type;
uint8_t* data = NULL;
@@ -329,76 +312,6 @@ class ServerSocket {
DISALLOW_IMPLICIT_CONSTRUCTORS(ServerSocket);
};
-class ListeningSocketRegistry {
- private:
- struct OSSocket {
- RawAddr address;
- int port;
- bool v6_only;
- bool shared;
- int ref_count;
- int socketfd;
-
- // Singly linked lists of OSSocket instances which listen on the same port
- // but on different addresses.
- OSSocket *next;
-
- OSSocket(RawAddr address, int port, bool v6_only, bool shared, int socketfd)
- : address(address), port(port), v6_only(v6_only), shared(shared),
- ref_count(0), socketfd(socketfd), next(NULL) {}
- };
-
- public:
- ListeningSocketRegistry() : mutex_(new Mutex()) {}
-
- // This function should be called from a dart runtime call in order to create
- // a new (potentially shared) socket.
- Dart_Handle CreateBindListen(Dart_Handle socket_object,
- RawAddr addr,
- intptr_t port,
- intptr_t backlog,
- bool v6_only,
- bool shared);
-
- // This should be called from the event handler for every kCloseEvent it gets
- // on listening sockets.
- //
- // Returns `true` if the last reference has been dropped and the underlying
- // socket can be closed.
- //
- // The caller is responsible for obtaining the mutex first, before calling
- // this function.
- bool CloseSafe(int socketfd);
-
- // Mark an existing socket as sharable if it is not already marked as
- // sharable.
- //
- // NOTE: This is a temporary measure until ServerSocketReference's are
- // removed.
- Dart_Handle MarkSocketFdAsSharableHack(int socketfd);
-
- Mutex *mutex() { return mutex_; }
-
- private:
- OSSocket *findOSSocketWithAddress(OSSocket *current, const RawAddr& addr) {
- while (current != NULL) {
- if (SocketAddress::AreAddressesEqual(current->address, addr)) {
- return current;
- }
- current = current->next;
- }
- return NULL;
- }
-
- std::map<intptr_t, OSSocket*> sockets_by_port_;
- std::map<intptr_t, OSSocket*> sockets_by_fd_;
- Mutex *mutex_;
-
- typedef std::map<intptr_t, OSSocket*>::iterator SocketsIterator;
-};
-
-extern ListeningSocketRegistry globalTcpListeningSocketRegistry;
-
} // namespace bin
} // namespace dart
« no previous file with comments | « dart/runtime/bin/io_natives.cc ('k') | dart/runtime/bin/socket.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698