Issue 895603002: VM: Improve polymorphic check-class in optimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 895603002: VM: Improve polymorphic check-class in optimized code. (Closed)

Created:
5 years, 10 months ago by Florian Schneider

Modified:
5 years, 10 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

VM: Improve polymorphic check-class in optimized code. Sort comparisons by decreasing IC count like we do for polymorphic inlining. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=43392

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -44 lines)			Patch
M	runtime/vm/flow_graph_compiler.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1	2 chunks	+10 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1	2 chunks	+10 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	2 chunks	+10 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1	2 chunks	+10 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	2 chunks	+9 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

Florian Schneider

5 years, 10 months ago (2015-02-03 12:31:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as r43392 (presubmit successful).